PR feedback

Author: jack-berg

README.md

@@ -128,7 +128,7 @@ Extensions to the OpenTelemetry SDK.
 |-------------------------------------------------------------------------------|------------------------------------------------------------------------------------|-----------------------------------------------------|-------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 | [SDK Autoconfigure](./sdk-extensions/autoconfigure)                           | Autoconfigure OpenTelemetry SDK from env vars, system properties, and SPI          | `opentelemetry-sdk-extension-autoconfigure`         | <!--VERSION_STABLE-->1.61.0<!--/VERSION_STABLE-->           | [![Javadocs](https://www.javadoc.io/badge/io.opentelemetry/opentelemetry-sdk-extension-autoconfigure.svg)](https://www.javadoc.io/doc/io.opentelemetry/opentelemetry-sdk-extension-autoconfigure)                 |
 | [SDK Autoconfigure SPI](./sdk-extensions/autoconfigure-spi)                   | Service Provider Interface (SPI) definitions for autoconfigure                     | `opentelemetry-sdk-extension-autoconfigure-spi`     | <!--VERSION_STABLE-->1.61.0<!--/VERSION_STABLE-->           | [![Javadocs](https://www.javadoc.io/badge/io.opentelemetry/opentelemetry-sdk-extension-autoconfigure-spi.svg)](https://www.javadoc.io/doc/io.opentelemetry/opentelemetry-sdk-extension-autoconfigure-spi)         |
-| [SDK Declarative Config](./sdk-extensions/jaeger-remote-sampler)              | Declarative config implementation for YAML-based SDK configuration                 | `opentelemetry-sdk-extension-declarative-config`    | TODO: add after first release                               | TODO: add after first release                                                                                                                                                                                     |
+| [SDK Declarative Config](./sdk-extensions/declarative-config)                 | Declarative config implementation for YAML-based SDK configuration                 | `opentelemetry-sdk-extension-declarative-config`    | TODO: add after first release                               | TODO: add after first release                                                                                                                                                                                     |
 | [SDK Jaeger Remote Sampler Extension](./sdk-extensions/jaeger-remote-sampler) | Sampler which obtains sampling configuration from remote Jaeger server             | `opentelemetry-sdk-extension-jaeger-remote-sampler` | <!--VERSION_STABLE-->1.61.0<!--/VERSION_STABLE-->           | [![Javadocs](https://www.javadoc.io/badge/io.opentelemetry/opentelemetry-sdk-extension-jaeger-remote-sampler.svg)](https://www.javadoc.io/doc/io.opentelemetry/opentelemetry-sdk-extension-jaeger-remote-sampler) |
 | [SDK Incubator](./sdk-extensions/incubator)                                   | SDK incubator, including YAML based view configuration, LeakDetectingSpanProcessor | `opentelemetry-sdk-extension-incubator`             | <!--VERSION_UNSTABLE-->1.61.0-alpha<!--/VERSION_UNSTABLE--> | [![Javadocs](https://www.javadoc.io/badge/io.opentelemetry/opentelemetry-sdk-extension-incubator.svg)](https://www.javadoc.io/doc/io.opentelemetry/opentelemetry-sdk-extension-incubator)                         |
 </details>

sdk-extensions/autoconfigure/build.gradle.kts

@@ -12,7 +12,6 @@ dependencies {
 
   compileOnly(project(":api:incubator"))
   compileOnly(project(":sdk-extensions:declarative-config"))
-  // compileOnly(project(":sdk-extensions:incubator"))
 
   annotationProcessor("com.google.auto.value:auto-value")
 

sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkBuilder.java

@@ -65,17 +65,17 @@ public final class AutoConfiguredOpenTelemetrySdkBuilder implements AutoConfigur
   private static final boolean DECLARATIVE_CONFIG_AVAILABLE;
 
   static {
-    boolean incubatorAvailable = false;
+    boolean declarativeConfigAvailable = false;
     try {
       Class.forName(
           "io.opentelemetry.sdk.declarativeconfig.DeclarativeConfiguration",
           false,
           AutoConfiguredOpenTelemetrySdkBuilder.class.getClassLoader());
-      incubatorAvailable = true;
+      declarativeConfigAvailable = true;
     } catch (ClassNotFoundException e) {
       // Not available
     }
-    DECLARATIVE_CONFIG_AVAILABLE = incubatorAvailable;
+    DECLARATIVE_CONFIG_AVAILABLE = declarativeConfigAvailable;
   }
 
   @Nullable private ConfigProperties config;

sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/DeclarativeConfigUtil.java

@@ -24,7 +24,7 @@
  * Utilities for interacting with ({@code
  * io.opentelemetry:opentelemetry-sdk-extension-declarative-config}, which is not guaranteed to be
  * present on the classpath. For all methods, callers MUST first separately reflectively confirm
- * that the incubator is available on the classpath.
+ * that declarative config is available on the classpath.
  */
 final class DeclarativeConfigUtil {