Skip to content

Commit 54d88fb

Browse files
committed
Security: Hardened file permissions for webhook certificates
Signed-off-by: rakshaak29 <rakshaak29@gmail.com>
1 parent 749e8f2 commit 54d88fb

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

  • pkg/webhook/util/writer

pkg/webhook/util/writer/fs.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ func prepareToWrite(dir string) error {
123123
switch {
124124
case os.IsNotExist(err):
125125
klog.Info("cert directory doesn't exist, creating", "directory", dir)
126-
// TODO: figure out if we can reduce the permission. (Now it's 0777)
127-
err = os.MkdirAll(dir, 0777)
126+
// Reduced directory permissions from 0777 to 0750 for better security.
127+
err = os.MkdirAll(dir, 0750)
128128
if err != nil {
129129
return fmt.Errorf("can't create dir: %v", dir)
130130
}
@@ -198,31 +198,31 @@ func ensureExist(dir string) error {
198198
}
199199

200200
func certToProjectionMap(cert *generator.Artifacts) map[string]atomic.FileProjection {
201-
// TODO: figure out if we can reduce the permission. (Now it's 0666)
201+
// Reduced file permissions from 0666 for better security.
202202
return map[string]atomic.FileProjection{
203203
CAKeyName: {
204204
Data: cert.CAKey,
205-
Mode: 0666,
205+
Mode: 0600,
206206
},
207207
CACertName: {
208208
Data: cert.CACert,
209-
Mode: 0666,
209+
Mode: 0640,
210210
},
211211
ServerCertName: {
212212
Data: cert.Cert,
213-
Mode: 0666,
213+
Mode: 0640,
214214
},
215215
ServerCertName2: {
216216
Data: cert.Cert,
217-
Mode: 0666,
217+
Mode: 0640,
218218
},
219219
ServerKeyName: {
220220
Data: cert.Key,
221-
Mode: 0666,
221+
Mode: 0600,
222222
},
223223
ServerKeyName2: {
224224
Data: cert.Key,
225-
Mode: 0666,
225+
Mode: 0600,
226226
},
227227
}
228228
}

0 commit comments

Comments
 (0)