Skip to content

Commit 70641c9

Browse files
Fixed groupcast steps in TC-SC-5.3 and TC-SM-1.1 for SVE (#71648)
- Make the verification step correct for IP address in TC-SC-5.3 (it was wrong in the manual verification steps). - Punt the conditions checks on Root Node in TC-SM-1.1 to post-1.6 to derisk needless failures. Testing: - CI still passes - 1.6 DUT does not fail the conditions if missing group cast.
1 parent ad94f83 commit 70641c9

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/app/tests/suites/certification/Test_TC_SC_5_3.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ tests:
439439
[1775758228.012] [2754009:2754011] [TOO] Sending cluster (0x00000006) command (0x00000002) on Group 1
440440
[1775758228.012] [2754009:2754011] [DMG] ICR moving to [AddingComm]
441441
[1775758228.012] [2754009:2754011] [DMG] ICR moving to [AddedComma]
442-
[1775758228.012] [2754009:2754011] [EM] <<< [E:14931i S:1 M:157645958] (G) Msg TX from 000000000001B669 to 1:FFFFFFFFFFFF0001 [CAE0] [UDP:[ff35:40:ff05::fa]:5540] --- Type 0001:08 (IM:InvokeCommandRequest) (B:66)
442+
[1775758228.012] [2754009:2754011] [EM] <<< [E:14931i S:1 M:157645958] (G) Msg TX from 000000000001B669 to 1:FFFFFFFFFFFF0001 [CAE0] [UDP:[ff05::fa]:5540] --- Type 0001:08 (IM:InvokeCommandRequest) (B:66)
443443
[1775758228.013] [2754009:2754011] [IN] Interface wlan0 has a link local address
444444
[1775758228.013] [2754009:2754011] [IN] Successfully send Multicast message on interface wlan0
445445
disabled: true

src/python_testing/TC_DeviceBasicComposition.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -340,9 +340,12 @@ def test_TC_SM_1_1(self):
340340
problem=f'Root node does not contain required cluster {c}', spec_location="Root node device type")
341341
self.fail_current_test()
342342

343-
self.print_step(6, "Verify that the specification version is 1.6 or above for the next steps")
343+
# NOTE: This was provisional in 1.6.0, but due to issues with reaching the finish line,
344+
# this step was punted to a later release to reduce friction for SVE participants.
345+
self.print_step(6, "Verify that the specification version is above 1.6.0 for the next steps")
344346
specification_version = root[Clusters.BasicInformation].get(Clusters.BasicInformation.Attributes.SpecificationVersion, 0)
345-
if specification_version >= 0x01060000:
347+
# Gate Groupcast requirements on Matter > 1.6.0
348+
if specification_version > 0x01060000:
346349
groupcast_feature_map = 0
347350
if Clusters.Groupcast in root:
348351
groupcast_feature_map = root[Clusters.Groupcast][Clusters.Groupcast.Attributes.FeatureMap]

0 commit comments

Comments
 (0)