Skip to content

Commit e136655

Browse files
committed
fix: ensure all Init() calls invoke base class methods for proper init
1 parent 5cdddf9 commit e136655

3 files changed

Lines changed: 6 additions & 1 deletion

File tree

src/libprojectM/Renderer/Backend/OpenGL/OpenGLCopyTexture.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ class OpenGLCopyTexture : public CopyTexture, public OpenGLRenderItem
2222
// Mark override for clarity and to avoid hiding warnings
2323
void Init() override
2424
{
25+
// Call both base class Init() to ensure proper initialization
2526
OpenGLRenderItem::Init();
27+
CopyTexture::Init();
2628
}
2729

2830
using OpenGLRenderItem::Init; // Unhide base Init() to avoid -Woverloaded-virtual warning

src/libprojectM/Renderer/Backend/OpenGL/OpenGLPresetTransition.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ class OpenGLPresetTransition : public PresetTransition, public OpenGLRenderItem
2424
// Mark override for clarity and to avoid hiding warnings
2525
void Init() override
2626
{
27+
// Call both base class Init() to ensure proper initialization
2728
OpenGLRenderItem::Init();
29+
PresetTransition::Init();
2830
}
2931

3032
using OpenGLRenderItem::Init; // Unhide base Init() to avoid -Woverloaded-virtual warning

src/libprojectM/Renderer/Backend/OpenGL/OpenGLRenderItem.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ class OpenGLRenderItem : public ::libprojectM::Renderer::RenderItem
2525
void Init() override;
2626

2727
protected:
28-
using ::libprojectM::Renderer::RenderItem::Init; // Unhide base Init() to avoid -Woverloaded-virtual warning
28+
// Unhide base Init() to avoid -Woverloaded-virtual warning and allow calling base from derived
29+
using ::libprojectM::Renderer::RenderItem::Init;
2930
GLuint m_vboID{0};
3031
GLuint m_vaoID{0};
3132
};

0 commit comments

Comments
 (0)