refactor: delegate exemplar writing to OM1 writer for consistency

Apply the same delegation pattern as histogram/summary: when
exemplarCompliance=false (default), delegate writeScrapeTimestampAndExemplar
and writeExemplar to om1Writer. When exemplarCompliance=true, apply the
OM2 spec requirement (drop exemplars without timestamps) then delegate
the actual writing to om1Writer.writeExemplar.

Extracts writeExemplar from om1Writer.writeScrapeTimestampAndExemplar so
OM2 can delegate exemplar formatting without duplicating it.

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Author: zeitlinger

prometheus-metrics-exposition-textformats/src/main/java/io/prometheus/metrics/expositionformats/OpenMetrics2TextFormatWriter.java

@@ -257,7 +257,7 @@ private void writeCompositeHistogramDataPoint(
       writer.write(" st@");
       writeOpenMetricsTimestamp(writer, data.getCreatedTimestampMillis());
     }
-    writeExemplarIfAllowed(writer, data.getExemplars().getLatest(), scheme);
+    writeExemplar(writer, data.getExemplars().getLatest(), scheme);
     writer.write('\n');
   }
 
@@ -339,7 +339,7 @@ private void writeCompositeSummaryDataPoint(
       writer.write(" st@");
       writeOpenMetricsTimestamp(writer, data.getCreatedTimestampMillis());
     }
-    writeExemplarIfAllowed(writer, data.getExemplars().getLatest(), scheme);
+    writeExemplar(writer, data.getExemplars().getLatest(), scheme);
     writer.write('\n');
   }
 
@@ -467,30 +467,30 @@ private void writeNameAndLabels(
   private void writeScrapeTimestampAndExemplar(
       Writer writer, DataPointSnapshot data, @Nullable Exemplar exemplar, EscapingScheme scheme)
       throws IOException {
+    if (!openMetrics2Properties.getExemplarCompliance()) {
+      om1Writer.writeScrapeTimestampAndExemplar(writer, data, exemplar, scheme);
+      return;
+    }
     if (data.hasScrapeTimestamp()) {
       writer.write(' ');
       writeOpenMetricsTimestamp(writer, data.getScrapeTimestampMillis());
     }
-    writeExemplarIfAllowed(writer, exemplar, scheme);
+    writeExemplar(writer, exemplar, scheme);
     writer.write('\n');
   }
 
-  private void writeExemplarIfAllowed(
-      Writer writer, @Nullable Exemplar exemplar, EscapingScheme scheme) throws IOException {
+  private void writeExemplar(Writer writer, @Nullable Exemplar exemplar, EscapingScheme scheme)
+      throws IOException {
     if (exemplar == null) {
       return;
     }
-    // In exemplarCompliance mode, exemplars MUST have a timestamp per the OM2 spec.
-    if (openMetrics2Properties.getExemplarCompliance() && !exemplar.hasTimestamp()) {
+    if (!openMetrics2Properties.getExemplarCompliance()) {
+      om1Writer.writeExemplar(writer, exemplar, scheme);
       return;
     }
-    writer.write(" # ");
-    writeLabels(writer, exemplar.getLabels(), null, 0, false, scheme);
-    writer.write(' ');
-    writeDouble(writer, exemplar.getValue());
+    // exemplarCompliance=true: exemplars MUST have a timestamp per the OM2 spec.
     if (exemplar.hasTimestamp()) {
-      writer.write(' ');
-      writeOpenMetricsTimestamp(writer, exemplar.getTimestampMillis());
+      om1Writer.writeExemplar(writer, exemplar, scheme);
     }
   }
 

prometheus-metrics-exposition-textformats/src/main/java/io/prometheus/metrics/expositionformats/OpenMetricsTextFormatWriter.java

@@ -424,26 +424,30 @@ private void writeNameAndLabels(
     writer.write(' ');
   }
 
-  private void writeScrapeTimestampAndExemplar(
+  void writeScrapeTimestampAndExemplar(
       Writer writer, DataPointSnapshot data, @Nullable Exemplar exemplar, EscapingScheme scheme)
       throws IOException {
     if (data.hasScrapeTimestamp()) {
       writer.write(' ');
       writeOpenMetricsTimestamp(writer, data.getScrapeTimestampMillis());
     }
     if (exemplar != null) {
-      writer.write(" # ");
-      writeLabels(writer, exemplar.getLabels(), null, 0, false, scheme);
-      writer.write(' ');
-      writeDouble(writer, exemplar.getValue());
-      if (exemplar.hasTimestamp()) {
-        writer.write(' ');
-        writeOpenMetricsTimestamp(writer, exemplar.getTimestampMillis());
-      }
+      writeExemplar(writer, exemplar, scheme);
     }
     writer.write('\n');
   }
 
+  void writeExemplar(Writer writer, Exemplar exemplar, EscapingScheme scheme) throws IOException {
+    writer.write(" # ");
+    writeLabels(writer, exemplar.getLabels(), null, 0, false, scheme);
+    writer.write(' ');
+    writeDouble(writer, exemplar.getValue());
+    if (exemplar.hasTimestamp()) {
+      writer.write(' ');
+      writeOpenMetricsTimestamp(writer, exemplar.getTimestampMillis());
+    }
+  }
+
   /**
    * Returns the full exposition name for a metric. If the original name already ends with the given
    * suffix (e.g. "_total" for counters), uses the original name directly. Otherwise, appends the