Temperature dependent OCP#4907
Closed
ksudhir111 wants to merge 16 commits intopybamm-team:developfrom
Closed
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4907 +/- ##
===========================================
- Coverage 98.70% 97.66% -1.04%
===========================================
Files 303 308 +5
Lines 23312 23762 +450
===========================================
+ Hits 23009 23207 +198
- Misses 303 555 +252 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hey @ksudhir111 this PR contains a bunch of your personal working files that should not go into PyBaMM. What are the specific files you meant to merge in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include temperature dependent OCP.
Have 1D thermal model
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests