Skip to content

Fix experiment initial guess regression#5452

Merged
MarcBerliner merged 3 commits intomainfrom
fix-initial-guess-regression
Apr 21, 2026
Merged

Fix experiment initial guess regression#5452
MarcBerliner merged 3 commits intomainfrom
fix-initial-guess-regression

Conversation

@MarcBerliner
Copy link
Copy Markdown
Member

Description

For experiment steps after the initial run, always get initial guesses from the previous model's state trajectory instead of the current model's initial conditions. Raise if the state variable cannot be found from the previous model

Fixes #5449

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (37dfaa5) to head (7b2d567).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5452   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         337      337           
  Lines       30930    30933    +3     
=======================================
+ Hits        30401    30404    +3     
  Misses        529      529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcBerliner MarcBerliner marked this pull request as ready for review April 21, 2026 15:40
@MarcBerliner MarcBerliner requested a review from a team as a code owner April 21, 2026 15:40
@MarcBerliner MarcBerliner merged commit 79fd15b into main Apr 21, 2026
44 of 46 checks passed
@MarcBerliner MarcBerliner deleted the fix-initial-guess-regression branch April 21, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CC→CV step transition passes algebraically-inconsistent state to rootfinder (regression in #5380)

2 participants