Skip to content

Commit 9faa0b2

Browse files
kastopiafacebook-github-bot
authored andcommitted
Add macOS SDK support to ExecuTorch Swift wrapper
Summary: Add MACOSX to the ExecuTorch Swift wrapper's supported SDKs and use platform-specific deps via select() to resolve the correct Apple vs AppleMac suffixed C++ targets per platform. This enables macOS binaries to link ExecuTorch without platform variant conflicts (duplicate symbols from mixing Apple and AppleMac transitive deps). Differential Revision: D99333988
1 parent 6823b33 commit 9faa0b2

1 file changed

Lines changed: 14 additions & 7 deletions

File tree

extension/apple/BUCK

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
2-
load("@fbsource//tools/build_defs:platform_defs.bzl", "IOS")
2+
load("@fbsource//tools/build_defs:platform_defs.bzl", "IOS", "MACOSX")
33
load("@fbsource//tools/build_defs/apple:fb_apple_library.bzl", "fb_apple_library")
44
load("@fbsource//tools/build_defs/apple:fb_apple_resource.bzl", "fb_apple_resource")
55
load("@fbsource//xplat/executorch/build/fb:clients.bzl", "EXECUTORCH_CLIENTS")
@@ -21,17 +21,24 @@ non_fbcode_target(_kind = fb_apple_library,
2121
"-Wno-switch-enum", # @cwt-override FIXME[T153556462]
2222
"-Wno-switch-default",
2323
],
24-
sdks = IOS,
24+
sdks = (IOS, MACOSX),
2525
test_deps = [
2626
":ExecuTorchTestResource",
2727
"//xplat/executorch/kernels/portable:generated_libApple",
2828
],
2929
visibility = EXECUTORCH_CLIENTS,
30-
deps = [
31-
"//xplat/executorch/extension/module:moduleApple",
32-
"//xplat/executorch/extension/tensor:tensorApple",
33-
"//xplat/executorch/runtime/platform:platformApple",
34-
],
30+
deps = select({
31+
"ovr_config//os:macos": [
32+
"//xplat/executorch/extension/module:moduleAppleMac",
33+
"//xplat/executorch/extension/tensor:tensorAppleMac",
34+
"//xplat/executorch/runtime/platform:platformAppleMac",
35+
],
36+
"DEFAULT": [
37+
"//xplat/executorch/extension/module:moduleApple",
38+
"//xplat/executorch/extension/tensor:tensorApple",
39+
"//xplat/executorch/runtime/platform:platformApple",
40+
],
41+
}),
3542
)
3643

3744
fb_apple_resource(

0 commit comments

Comments
 (0)