Add human-readable descriptions to CheckCode returns in linux/http exploit modules (A-M)

Author: adfoster-r7

modules/exploits/linux/http/accellion_fta_getstatus_oauth.rb

@@ -74,7 +74,7 @@ def check
     })
 
     unless res && res.code == 200 && res.body.to_s =~ /"result_msg":"MD5 token is invalid"/
-      return Exploit::CheckCode::Safe
+      return Exploit::CheckCode::Safe('The target is not vulnerable')
     end
 
     res = send_request_cgi({
@@ -87,10 +87,10 @@ def check
     })
 
     unless res && res.code == 200 && res.body.to_s =~ /"result_msg":"Success","transaction_id":"/
-      return Exploit::CheckCode::Safe
+      return Exploit::CheckCode::Safe('The target is not vulnerable')
     end
 
-    Msf::Exploit::CheckCode::Vulnerable
+    Msf::Exploit::CheckCode::Vulnerable('The target is vulnerable')
   end
 
   def exploit

modules/exploits/linux/http/advantech_switch_bash_env_exec.rb

@@ -75,19 +75,19 @@ def check
     )
     if !res
       vprint_error("No response from host")
-      return Exploit::CheckCode::Unknown
+      return Exploit::CheckCode::Unknown('Could not determine the target status')
     elsif res.headers['Server'] =~ /Boa\/(.*)/
       vprint_status("Found Boa version #{$1}")
     else
       print_status("Target is not a Boa web server")
-      return Exploit::CheckCode::Safe
+      return Exploit::CheckCode::Safe('The target is not vulnerable')
     end
 
     if res.body.to_s.index('127.0.0.1 ping statistics')
-      return Exploit::CheckCode::Detected
+      return Exploit::CheckCode::Detected('The target service was detected')
     else
       vprint_error("Target does not appear to be an Advantech switch")
-      return Expoit::CheckCode::Safe
+      return Expoit::CheckCode::Safe('The target is not vulnerable')
     end
   end
 

modules/exploits/linux/http/airties_login_cgi_bof.rb

@@ -69,13 +69,13 @@ def check
       })
 
       if res && [200, 301, 302].include?(res.code) && res.body.to_s =~ /login.html\?ErrorCode=2/
-        return Exploit::CheckCode::Detected
+        return Exploit::CheckCode::Detected('The target service was detected')
       end
     rescue ::Rex::ConnectionError
-      return Exploit::CheckCode::Unknown
+      return Exploit::CheckCode::Unknown('Could not determine the target status')
     end
 
-    Exploit::CheckCode::Unknown
+    Exploit::CheckCode::Unknown('Could not determine the target status')
   end
 
   def exploit

modules/exploits/linux/http/alienvault_exec.rb

@@ -87,9 +87,9 @@ def check
     })
 
     if res && res.code == 200 && res.body =~ /XPATH syntax error: ':#{r}'/
-      Exploit::CheckCode::Vulnerable
+      Exploit::CheckCode::Vulnerable('The target is vulnerable')
     else
-      Exploit::CheckCode::Safe
+      Exploit::CheckCode::Safe('The target is not vulnerable')
     end
   end
 

modules/exploits/linux/http/alienvault_sqli_exec.rb

@@ -75,10 +75,10 @@ def check
     })
 
     if res && res.code == 200 && res.body =~ /#{marker}726F6F7440[0-9a-zA-Z]+#{marker}/ # 726F6F7440 = root
-      return Exploit::CheckCode::Vulnerable
+      return Exploit::CheckCode::Vulnerable('The target is vulnerable')
     else
       print_status("#{res.body}")
-      return Exploit::CheckCode::Safe
+      return Exploit::CheckCode::Safe('The target is not vulnerable')
     end
   end
 

modules/exploits/linux/http/apache_airflow_dag_rce.rb

@@ -103,7 +103,7 @@ def check
     end
 
     unless Rex::Version.new(version_number) < Rex::Version.new('1.10.11')
-      return CheckCode::Safe
+      return CheckCode::Safe("Version #{version_number} is not vulnerable")
     end
 
     vprint_status(
@@ -115,7 +115,7 @@ def check
     check_task
     check_unpaused
 
-    return CheckCode::Appears
+    return CheckCode::Appears("Version #{version_number} appears to be vulnerable")
   end
 
   def check_api

modules/exploits/linux/http/apache_continuum_cmd_exec.rb

@@ -56,11 +56,11 @@ def check
     )
 
     if res && res.body.include?('1.4.2')
-      CheckCode::Appears
+      CheckCode::Appears('The target appears to be vulnerable')
     elsif res && res.code == 200
-      CheckCode::Detected
+      CheckCode::Detected('The target service was detected')
     else
-      CheckCode::Safe
+      CheckCode::Safe('The target is not vulnerable')
     end
   end
 

modules/exploits/linux/http/apache_couchdb_cmd_exec.rb

@@ -77,16 +77,16 @@ def post_auth?
 
   def check
     get_version
-    return CheckCode::Unknown if @version.nil?
+    return CheckCode::Unknown('Could not determine the target status') if @version.nil?
 
     version = Rex::Version.new(@version)
-    return CheckCode::Unknown if version.version.empty?
+    return CheckCode::Unknown('Could not determine the target status') if version.version.empty?
 
     vprint_status "Found CouchDB version #{version}"
 
-    return CheckCode::Appears if version < Rex::Version.new('1.7.0') || version.between?(Rex::Version.new('2.0.0'), Rex::Version.new('2.1.0'))
+    return CheckCode::Appears("Version #{version} appears to be vulnerable") if version < Rex::Version.new('1.7.0') || version.between?(Rex::Version.new('2.0.0'), Rex::Version.new('2.1.0'))
 
-    CheckCode::Safe
+    CheckCode::Safe("Version #{version} is not vulnerable")
   end
 
   def exploit

modules/exploits/linux/http/apache_druid_js_rce.rb

@@ -138,11 +138,11 @@ def check
     end
 
     unless res.code == 200
-      return CheckCode::Safe
+      return CheckCode::Safe('The target is not vulnerable')
     end
 
     if res.body.include?(genecho)
-      return CheckCode::Vulnerable
+      return CheckCode::Vulnerable('The target is vulnerable')
     end
 
     CheckCode::Unknown('Target does not seem to be running Apache Druid.')

modules/exploits/linux/http/artica_proxy_auth_bypass_service_cmds_peform_command_injection.rb

@@ -93,9 +93,9 @@ def check
     end
     rand_string = Rex::Text.rand_text_alphanumeric(4..16)
     if execute_command("echo #{Rex::Text.encode_base64(rand_string)}|base64 -d").include?(rand_string)
-      CheckCode::Appears
+      CheckCode::Appears('The target appears to be vulnerable')
     else
-      CheckCode::Safe
+      CheckCode::Safe('The target is not vulnerable')
     end
   end