Skip to content

Commit 671065f

Browse files
authored
Split toolchains for example vs plugin (#150)
* Split example to latest toolchain, keep plugin compatible - example: AGP 8.11.1 + Gradle 8.14.3, namespace, SDK 35, minSdk 21 - plugin: keep AGP 7.1.2 + Gradle 7.4, drop Flutter 1.x test sources - add jsr305 to satisfy R8 missing javax.annotation.Nullable - CI: run Flutter 3.29/3.38, use JDK 17 for example + JDK 11 for plugin check * Update rollbar_flutter/example/android/app/build.gradle
1 parent 48d57f1 commit 671065f

15 files changed

Lines changed: 232 additions & 187 deletions

File tree

.github/workflows/ci.yml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,14 @@ jobs:
1111
name: Flutter version ${{ matrix.flutter_version }} (Android)
1212
strategy:
1313
matrix:
14-
flutter_version: ["3.29.2"]
14+
flutter_version: ["3.29.2", "3.38.5"]
1515

1616
steps:
1717
- uses: actions/checkout@v4
18-
- uses: actions/setup-java@v1
18+
- uses: actions/setup-java@v4
1919
with:
20-
java-version: "11.x"
20+
distribution: "temurin"
21+
java-version: "17"
2122
- uses: subosito/flutter-action@v2
2223
with:
2324
flutter-version: ${{ matrix.flutter_version }}
@@ -60,12 +61,22 @@ jobs:
6061
- name: Run rollbar_flutter Pana checks
6162
working-directory: ./rollbar_flutter
6263
run: ../build_tools/run-pana ${{ matrix.flutter_version }}
64+
- name: Use JDK 11 for plugin Gradle check
65+
uses: actions/setup-java@v4
66+
with:
67+
distribution: "temurin"
68+
java-version: "11"
6369
- name: Test rollbar_flutter Android plugin
6470
working-directory: ./rollbar_flutter/android
6571
run: |
6672
export FLUTTER_SDK=$(../../build_tools/find-flutter-sdk)
6773
echo $FLUTTER_SDK
6874
./gradlew check
75+
- name: Use JDK 17 for example build
76+
uses: actions/setup-java@v4
77+
with:
78+
distribution: "temurin"
79+
java-version: "17"
6980
- name: Build rollbar_flutter Android example
7081
working-directory: ./rollbar_flutter/example/
7182
run: flutter build apk
@@ -87,7 +98,7 @@ jobs:
8798
name: Flutter version ${{ matrix.flutter_version }} (iOS)
8899
strategy:
89100
matrix:
90-
flutter_version: ["3.29.2"]
101+
flutter_version: ["3.29.2", "3.38.5"]
91102

92103
steps:
93104
- uses: actions/checkout@v4

build_tools/SDK_VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.38.4
1+
3.38.5

rollbar_flutter/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,15 @@
33
## 1.5.2
44

55
### FIX
6+
67
- Add missing namespace to support AGP 7.0+.
8+
- Add jsr305 annotations to satisfy R8 for javax.annotation.Nullable.
9+
10+
### BUILD
11+
12+
- Update the Android example to AGP 8.11.1, Gradle 8.14.3, and SDK 35.
13+
- Keep the Android plugin build on AGP 7.1.2 and Gradle 7.4 for compatibility.
14+
- Remove Flutter 1.x test source set handling in the Android plugin.
715

816
## 1.5.1
917

rollbar_flutter/android/build.gradle

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ def flutterVersion = "1.0.0-${engineVersion}"
8282
dependencies {
8383
api 'com.rollbar:rollbar-java:1.7.8'
8484
api 'com.rollbar:rollbar-android:1.7.8@aar'
85+
api 'com.google.code.findbugs:jsr305:3.0.2'
8586
compileOnly "io.flutter:flutter_embedding_debug:${flutterVersion}"
8687

8788
testImplementation "io.flutter:flutter_embedding_debug:${flutterVersion}"
@@ -167,17 +168,7 @@ task spotbugsMain(type: com.github.spotbugs.snom.SpotBugsTask) {
167168
}
168169
}
169170

170-
String flutterCompatVersion = Paths
171-
.get(flutterRoot, "version")
172-
.toFile()
173-
.text
174-
.trim()
175-
176-
if (flutterCompatVersion.startsWith('1.')) {
177-
android.sourceSets.test.java.srcDir file('src/testflutter1/java/')
178-
} else {
179-
android.sourceSets.test.java.srcDir file('src/testflutter/java/')
180-
}
171+
android.sourceSets.test.java.srcDir file('src/testflutter/java/')
181172

182173
afterEvaluate {
183174
if (project.tasks.getByName("check")) {
4.11 KB
Binary file not shown.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-bin.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

0 commit comments

Comments
 (0)