Skip to content

addcol-shell quotes shell syntax incorrectly #3026

@midichef

Description

@midichef

Small description
touch "filename with space.txt" then vd then addcol-shell then input ls $filename
Files that don't contain a space have the command will succeed, but files with space will have an error in the stderr column: ls: cannot access "'filename with space.txt'": No such file or directory.

It seems to be related to unneeded quoting being added here:

arg = shlex.quote(str(context[arg[1:]]))

As a second issue, | commands do not succeed:
z; echo $filename |sed -e s/space// gives a cell showing echo $text |sed -e s/space//
So there seems to have been a regression since #1023

Configuration
Latest develop branch. Ubuntu 24.04.4, zsh.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions