fix(docker): resolve the issue of Unrecognized field "child" (#6359) (#6360)

* test(docker): add a test to demonstrate the issue of `Failed to parse ResponseBody : Unrecognized field "child"`

* fix(docker): resolve the issue of `Failed to parse ResponseBody : Unrecognized field "child"` when google cloud artifact registry responds with additional fields upon invoking tags list api

(cherry picked from commit 7c4514a)

Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>

Author: mergify[bot]

clouddriver-docker/src/main/groovy/com/netflix/spinnaker/clouddriver/docker/registry/api/v2/client/DockerRegistryClient.groovy

@@ -16,6 +16,7 @@
 
 package com.netflix.spinnaker.clouddriver.docker.registry.api.v2.client
 
+import com.fasterxml.jackson.databind.DeserializationFeature
 import com.fasterxml.jackson.databind.ObjectMapper
 import com.google.gson.Gson
 import com.netflix.spinnaker.clouddriver.docker.registry.api.v2.DockerUserAgent
@@ -163,6 +164,15 @@ class DockerRegistryClient {
 
   final static String userAgent = DockerUserAgent.getUserAgent()
   final int paginateSize
+  static ObjectMapper objectMapper
+
+  private static ObjectMapper getObjectMapper() {
+    if (objectMapper == null) {
+      objectMapper = new ObjectMapper()
+      objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
+    }
+    return objectMapper
+  }
 
   String getBasicAuth() {
     return tokenService?.basicAuth
@@ -317,9 +327,8 @@ class DockerRegistryClient {
       throw new DockerRegistryOperationException("ResponseBody cannot be null")
     }
     try {
-      def objectMapper = new ObjectMapper()
       def jsonString = responseBody.string()
-      return objectMapper.readValue(jsonString, aClass)
+      return getObjectMapper().readValue(jsonString, aClass)
     } catch (Exception e) {
       throw new DockerRegistryOperationException("Failed to parse ResponseBody : ${e.message}", e)
     }

clouddriver-docker/src/test/java/com/netflix/spinnaker/clouddriver/docker/registry/api/v2/client/DockerRegistryClientTest.java

@@ -217,4 +217,35 @@ public void getTagsWithNextLinkEncryptedAndEncoded() {
             urlMatching(
                 tagsListEndPointMinusQueryParams + "\\?last=" + expectedEncodedParam + "&n=5")));
   }
+
+  @Test
+  public void testTagsResponse_With_AdditionalFields() throws JsonProcessingException {
+    Map<String, Object> tagsResponse =
+        Map.of(
+            "child",
+            new String[] {},
+            "manifest",
+            Map.of(
+                "sha256:ec1b05dxxxxxxxxxxxxxxxxxxxedb1d6a4",
+                Map.of(
+                    "mediaType",
+                    "application/vnd.docker.distribution.manifest.v2+json",
+                    "tag",
+                    new String[] {"1.0.0", "2.0.1"})),
+            "name",
+            "library/nginx",
+            "tags",
+            new String[] {"1", "1-alpine", "1-alpine-otel", "1-alpine-perl", "1-alpine-slim"});
+
+    wmDockerRegistry.stubFor(
+        WireMock.get(urlMatching("/v2/library/nginx/tags/list\\?n=5"))
+            .willReturn(
+                aResponse()
+                    .withStatus(HttpStatus.OK.value())
+                    .withBody(objectMapper.writeValueAsString(tagsResponse))));
+
+    DockerRegistryTags dockerRegistryTags = dockerRegistryClient.getTags("library/nginx");
+    String[] tags = (String[]) tagsResponse.get("tags");
+    assertIterableEquals(Arrays.asList(tags), dockerRegistryTags.getTags());
+  }
 }