Skip to content

Commit dbfc2b0

Browse files
committed
Merge remote-tracking branch 'origin/intellij14.1' into intellij15
# Conflicts: # gradle.properties
2 parents 663fcd6 + 2274e63 commit dbfc2b0

3 files changed

Lines changed: 12 additions & 10 deletions

File tree

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
ideaVersion=IC-15.0.5
22
ijPluginRepoChannel=
33
downloadIdeaSources=false
4-
version=1.1.0-142
4+
version=1.1.1-142
55
javaVersion=1.6

src/main/java/com/urswolfer/intellij/plugin/gerrit/push/GerritPushExtensionPanel.java

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,17 +97,14 @@ public void registerGerritPushTargetPanel(GerritPushTargetPanel gerritPushTarget
9797
public void initialized() {
9898
initialized = true;
9999

100-
if (gerritPushTargetPanels.size() == 1) {
101-
String branchName = gerritPushTargetPanels.values().iterator().next();
102-
103-
Optional<String> gitReviewBranchName = getGitReviewBranchName();
104-
105-
branchTextField.setText(gitReviewBranchName.or(branchName));
106-
}
107-
108100
// force a deferred update (changes are monitored only after full construction of dialog)
109101
SwingUtilities.invokeLater(new Runnable() {
110102
public void run() {
103+
if (gerritPushTargetPanels.size() == 1) {
104+
String branchName = gerritPushTargetPanels.values().iterator().next();
105+
Optional<String> gitReviewBranchName = getGitReviewBranchName();
106+
branchTextField.setText(gitReviewBranchName.or(branchName));
107+
}
111108
initDestinationBranch();
112109
}
113110
});
@@ -117,7 +114,8 @@ private Optional<String> getGitReviewBranchName() {
117114
Optional<String> branchName = Optional.absent();
118115

119116
DataContext dataContext = DataManager.getInstance().getDataContextFromFocus().getResult();
120-
Optional<Project> openedProject = Optional.fromNullable(CommonDataKeys.PROJECT.getData(dataContext));
117+
Optional<Project> openedProject = dataContext != null ?
118+
Optional.fromNullable(CommonDataKeys.PROJECT.getData(dataContext)) : Optional.<Project>absent();
121119

122120
if (openedProject.isPresent()) {
123121
String gitReviewFilePath = Joiner.on(File.separator).join(

src/main/resources/META-INF/plugin.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,10 @@
8989
href="https://github.com/uwolfer/gerrit-intellij-plugin#pre-releases">
9090
https://github.com/uwolfer/gerrit-intellij-plugin#pre-releases</a>.</li>
9191
92+
<li>1.1.1</li>
93+
<ul>
94+
<li>fix for push dialog which did not appear in some situations (fix for a recent change which is included in last release)</li>
95+
</ul>
9296
<li>1.1.0</li>
9397
<ul>
9498
<li>add support for Gerrit 2.15+ push options (wip, private, publish-comments, hashtag)</li>

0 commit comments

Comments
 (0)