Make sure conditional taints aren't registered directly

Author: danog

src/Psalm/Codebase.php

@@ -365,6 +365,9 @@ public function getOrRegisterTaint(string $taint_type, ?CodeLocation $location =
             }
             throw new RuntimeException($err);
         }
+        if ($taint_type[0] === '(') {
+            throw new AssertionError('Conditional taints cannot be registered directly');
+        }
         $id = 1 << ($this->taint_count++);
         $this->custom_taints[$id] = $taint_type;
         $this->taint_map[$taint_type] = $id;

src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeDocblockScanner.php

@@ -369,7 +369,7 @@ public static function addDocblockInfo(
 
         foreach ($docblock_info->removed_taints as $removed_taint) {
             if ($removed_taint[0] === '(') {
-                self::handleRemovedTaint(
+                self::handleConditionallyRemovedTaint(
                     $codebase,
                     $stmt,
                     $aliases,
@@ -1150,7 +1150,7 @@ private static function handleTaintFlow(
      * @param array<string, non-empty-array<string, Union>> $function_template_types
      * @param array<string, non-empty-array<string, Union>> $class_template_types
      */
-    private static function handleRemovedTaint(
+    private static function handleConditionallyRemovedTaint(
         Codebase $codebase,
         PhpParser\Node\FunctionLike $stmt,
         Aliases $aliases,