Merge pull request #5476 from willmmiles/ipv6-filter-oops

willmmiles · web-flow · commit c81981490420 · 2026-04-04T21:10:55.000-04:00
Fix leak in blockRouterAdvertisements
diff --git a/wled00/network.cpp b/wled00/network.cpp
@@ -377,6 +377,7 @@ bool isWiFiConfigured() {
 static u8_t blockRouterAdvertisements(void* arg, struct raw_pcb* pcb, struct pbuf* p, const ip_addr_t* addr) {
   // ICMPv6 type is the first byte of the payload, so we skip the header
   if (p->len > 0 && (pbuf_get_at(p, sizeof(struct ip6_hdr)) == ICMP6_TYPE_RA)) {
+    pbuf_free(p);
     return 1; // claim the packet — lwIP will not pass it further
   }
   return 0; // not consumed, pass it on

Original file line number	Diff line number	Diff line change
`@@ -377,6 +377,7 @@ bool isWiFiConfigured() {`
`377`	`377`	`static u8_t blockRouterAdvertisements(void* arg, struct raw_pcb* pcb, struct pbuf* p, const ip_addr_t* addr) {`
`378`	`378`	`// ICMPv6 type is the first byte of the payload, so we skip the header`
`379`	`379`	`if (p->len > 0 && (pbuf_get_at(p, sizeof(struct ip6_hdr)) == ICMP6_TYPE_RA)) {`
	`380`	`+ pbuf_free(p);`
`380`	`381`	`return 1; // claim the packet — lwIP will not pass it further`
`381`	`382`	`}`
`382`	`383`	`return 0; // not consumed, pass it on`