Skip to content

603: Fix string iteration in aliasing#604

Merged
charles-turner-1 merged 3 commits intomainfrom
603-normalise-value-str-explode
Apr 20, 2026
Merged

603: Fix string iteration in aliasing#604
charles-turner-1 merged 3 commits intomainfrom
603-normalise-value-str-explode

Conversation

@charles-turner-1
Copy link
Copy Markdown
Collaborator

@charles-turner-1 charles-turner-1 commented Apr 20, 2026

Change Summary

  • Test that we don't iterate over strings when they're in a collection via an ill-thought through str fallback. 947b02b
  • Add code fixing it. aa27725

Related issue number

Closes #603

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • [N/A] Documentation reflects the changes where applicable

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.32%. Comparing base (c55785b) to head (aa27725).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
- Coverage   99.32%   99.32%   -0.01%     
==========================================
  Files          19       19              
  Lines        1927     1926       -1     
==========================================
- Hits         1914     1913       -1     
  Misses         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-turner-1
Copy link
Copy Markdown
Collaborator Author

@rbeucher Take a look at Benoit's issue linked to this - I feel like we might wanna link up some sort of automated bug triage/investigator? Took me about 5 minutes to fix it thanks to how well formulated it was

@charles-turner-1 charles-turner-1 merged commit 4f24cef into main Apr 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

AliasedDataframeCatalog._normalise_value explodes string values into their characters, corrupting queries

2 participants