Closed
Conversation
joshlf
force-pushed
the
roll
branch
2 times, most recently
from
c44afa2 to
57c0c98
Compare
Contributor
Author
|
Looks like this update breaks expectations from Aeneas and Eurydice. How do you normally handle that? Is there a recommended graceful upgrade path? |
joshlf
commented
Apr 16, 2026
Comment on lines
22
to
-24
| /// Reflects [`rustc_hir::def::DefKind`] | ||
| #[derive(AdtInto)] | ||
| #[args(<S>, from: rustc_hir::def::DefKind, state: S as tcx)] |
Contributor
Author
There was a problem hiding this comment.
Calling this out – not sure of the significance of this change or why the agent did it.
| ForeignMod, | ||
| AnonConst, | ||
| InlineConst, | ||
| #[disable_mapping] |
Contributor
Author
There was a problem hiding this comment.
Calling this out – not sure of the significance of this change or why the agent did it.
Comment on lines
-676
to
-687
| // In a case like: | ||
| // ``` | ||
| // impl<T, U> Trait for Result<T, U> | ||
| // where | ||
| // for<'a> &'a Result<T, U>: IntoIterator, | ||
| // for<'a> <&'a Result<T, U> as IntoIterator>::Item: Copy, | ||
| // {} | ||
| // ``` | ||
| // the `&'a Result<T, U> as IntoIterator` trait ref has escaping bound variables | ||
| // yet we dont have a binder around (could even be several). Binding this correctly | ||
| // is therefore difficult. Since our trait resolution ignores lifetimes anyway, we | ||
| // just erase them. See also https://github.com/hacspec/hax/issues/747. |
Contributor
Author
There was a problem hiding this comment.
Calling this out – should I keep this comment, or was the agent right to remove it?
Member
|
there is already #1033 waiting that bumps it a bit forward, let's wait for that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.