common: sync ONBOARD_COMPUTER_STATUS (id=390) from upstream mavlink/mavlink #499
Merged
peterbarker merged 1 commit intoArduPilot:masterfrom Apr 16, 2026
Conversation
peterbarker
requested changes
Apr 14, 2026
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
Sorry to be strict here, but I am trying to make our common.xml identical to mavlink/mavlink/master so we can stay in sync more easily.
peterbarker
requested changes
Apr 14, 2026
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
Apologies for missing this on my first pass.
Author
No worries! |
|
Incidentally.... you can set a bit |
Author
that will be helpful as a workaround in the meantime hehehe |
…avlink ONBOARD_COMPUTER_STATUS was added to mavlink/mavlink in August 2019 (PR mavlink#1186) and has been part of the standard common.xml ever since. This commit syncs it into ArduPilot/mavlink so that ArduPilot builds its CRC_EXTRA map with knowledge of message ID 390, enabling it to validate and route frames sent by companion computers instead of silently dropping them. Also adds the COMPUTER_STATUS_FLAGS bitmask enum referenced by the status_flags extension field.
peterbarker
force-pushed
the
feature/include-onboard-computer-status
branch
from
26ac12f to
9e55375
Compare
|
Merged this - ta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ONBOARD_COMPUTER_STATUS (id=390) was added to the upstream mavlink/mavlink common.xml in August 2019 via PR mavlink#1186 and has been part of the standard library ever since, including the auto-generated C library (mavlink_msg_onboard_computer_status.h in mavlink/c_library_v2).
The ArduPilot/mavlink fork has not yet synced this message. As a result, ArduPilot builds its CRC_EXTRA map and routing table at compile time with no entry for id=390. Any incoming MAVLink2 frame with that ID is silently rejected at the routing layer — even when sent by a legitimate companion computer on the same vehicle over a trusted serial link. There is no log entry and no NAK; the frame is simply dropped.
See this issue: ArduPilot/ardupilot#32777
Changes
message_definitions/v1.0/common.xml: addCOMPUTER_STATUS_FLAGSbitmask enum andONBOARD_COMPUTER_STATUSmessage block, copied verbatim from upstream mavlink/mavlink at current HEAD. Insertion point preserves numeric ordering (after id=388, before the existing Rover-specific block at id=9000).Notes
<extensions/>marker andstatus_flagsfield are part of the canonical upstream definition and are included unchanged.