Fix revenue dashboard: tenant isolation, accuracy, and precision bugs#110
Open
CodingwithMeet wants to merge 1 commit into
Open
Fix revenue dashboard: tenant isolation, accuracy, and precision bugs#110CodingwithMeet wants to merge 1 commit into
CodingwithMeet wants to merge 1 commit into
Conversation
This commit addresses three critical production issues:
1. **Cross-tenant data leak (privacy)**: Cache key was property-scoped only,
allowing clients to see each other's cached revenue on page refresh.
Fixed by including tenant_id in cache key: revenue:{tenant_id}:{property_id}
2. **Wrong revenue totals (accuracy)**: DatabasePool referenced non-existent
settings, failing silently and returning mock data instead of real
reservations. Fixed by using the actual DATABASE_URL and normalizing it
to postgresql+asyncpg:// for async operations.
3. **Cents drift (precision)**: Money was converted through float() which
lost precision on NUMERIC(10,3) amounts. Fixed by using Decimal
end-to-end with ROUND_HALF_UP rounding to 2 decimals.
4. **Bonus: Timezone bucketing**: Monthly revenue was bucketed in naive UTC
instead of the property's local timezone, causing bookings to land in
the wrong month. Fixed by building month boundaries with the property's
ZoneInfo.
Changes:
- services/cache.py: Tenant-scoped cache key
- services/reservations.py: Decimal rounding, real DB connection, timezone-aware month bucketing
- core/database_pool.py: URL normalization, idempotent init, async pool
- api/v1/dashboard.py: Decimal rounding before serialization
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses three critical production issues:
Cross-tenant data leak (privacy): Cache key was property-scoped only, allowing clients to see each other's cached revenue on page refresh. Fixed by including tenant_id in cache key: revenue:{tenant_id}:{property_id}
Wrong revenue totals (accuracy): DatabasePool referenced non-existent settings, failing silently and returning mock data instead of real reservations. Fixed by using the actual DATABASE_URL and normalizing it to postgresql+asyncpg:// for async operations.
Cents drift (precision): Money was converted through float() which lost precision on NUMERIC(10,3) amounts. Fixed by using Decimal end-to-end with ROUND_HALF_UP rounding to 2 decimals.
Bonus: Timezone bucketing: Monthly revenue was bucketed in naive UTC instead of the property's local timezone, causing bookings to land in the wrong month. Fixed by building month boundaries with the property's ZoneInfo.
Changes: