Fix add channel button adding default channel when channel axis is 0#31
Fix add channel button adding default channel when channel axis is 0#31
Conversation
will-moore
left a comment
There was a problem hiding this comment.
Thanks for the fix.
It would be really handy to enable netlify builds on this repo so that each PR is automatically deployed. We used to have that a while back on hms vizarr repo.
Tested locally and it's looks good 👍
@will-moore I believe we have automated deployments when the main branch is updated, @davehorsfall may be able to confirm this. Since we are working in a main -> dev -> feature branch workflow there will be a slight delay in the fix being deployed. |
|
I meant that it would be useful for testing PRs before they are merged. We have this enabled on ome-ngff-validator e.g. see ome/ome-ngff-validator#64 and a bunch of other repos. It's very easy and free to set up - login to netlify with your github account (the BioNGFF account) and point it at the repos you want to deploy. |
Ah, I see now - thanks Will. This does indeed seem useful, I'll chat to the team and see if we can get it set up. |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Adding a channel automatically added the default channel (first one in list) due to a mistake in the logic when checking if the channel_axis was defined (unintentionally excluding 0 values as well as null).
Fixes # (issue)
Fixes #17
Type of change
Checklist
npm test)pre-commit run --all-files)