Ozx support#56
Conversation
✅ Deploy Preview for biongff-vizarr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| "@zarrita/storage": "0.1.3", | ||
| "@zarrita/storage": "0.1.4", | ||
| "deck.gl": "~9.0.0", | ||
| "http-server": "^14.1.1", |
There was a problem hiding this comment.
Why has this been added as a dep? Where is it being used?
|
|
||
| import react from "@vitejs/plugin-react"; | ||
| import { defineConfig } from "vite"; | ||
| import { defineConfig, loadEnv } from "vite"; |
There was a problem hiding this comment.
Why is loadEnv loaded here?
| import { useViewState } from "../hooks"; | ||
| import { useAxisNavigation } from "../hooks/useAxisNavigation"; | ||
| import { layerAtoms, viewportAtom } from "../state"; | ||
| import { layerAtoms, sourceErrorAtom, viewportAtom } from "../state"; |
There was a problem hiding this comment.
Are these additions needed, or leftovers?
| import { fitImageToViewport, getLayerSize, resolveLoaderFromLayerProps } from "../utils"; | ||
|
|
||
| import type { DeckGLRef, OrthographicViewState, PickingInfo } from "deck.gl"; | ||
| import { useSetAtom } from "jotai"; |
There was a problem hiding this comment.
Are these additions needed, or leftovers?
| */ | ||
|
|
||
| export function resolveAttrs(attrs: zarr.Attributes): zarr.Attributes { | ||
| if ("omero" in attrs && "ome" in attrs) { |
There was a problem hiding this comment.
My understanding here, is that this addition is to handle mixed OME metadata formats more robustly. Specifically, if both ome AND omero exist, then construct a merged, normalised object.
I think we both agree, it can be very difficult to quickly and intuitively understand, at a glance, how this type of decision making is done throughout the viewer. Especially as the Viewer is retrosepctively trying to support older metadata schemas (such as this OMERO-style metadata).
Not for this PR, but can we open an issue on how to capture an overview of this decision making? I think I'm imaging a graphical decision tree, that outlines when a slight deviation from the NGFF schema is caught (for example this Channel info being in the OMERO-style metadata).
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@davehorsfall thanks for the review. I have addressed your comments, merged dev, and added a test for the kingsnake.ozx file. Happy for you to accept and merge if you are happy. |
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
Description
Fixes # (issue)
#46 #43 #40 #29 #27 #19
Related to # (if applicable)
Type of change