Skip to content

Anndata zarr port#65

Open
AlexSurtees wants to merge 8 commits intodevfrom
anndata-zarr-port
Open

Anndata zarr port#65
AlexSurtees wants to merge 8 commits intodevfrom
anndata-zarr-port

Conversation

@AlexSurtees
Copy link
Copy Markdown
Collaborator

@AlexSurtees AlexSurtees commented Mar 26, 2026

Description

Ports the anndata-zarr plugin from https://github.com/BioNGFF/biongff-viewer

Fixes # (issue)
#58

Type of change

  • 🐛 Bug fix (non-breaking change that resolves an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • ⚡ Optimisation (non-breaking improvement to performance or efficiency)
  • 🧩 Documentation (adds or improves documentation)
  • 🧱 Maintenance (refactor, dependency update, CI/CD, etc.)
  • 🔥 Breaking change (fix or feature that causes existing functionality to change)

Checklist

  • All tests pass (eg. npm test)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)
  • Documentation updated (if required)

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 26, 2026

Deploy Preview for biongff-vizarr ready!

Name Link
🔨 Latest commit 0643b7f
🔍 Latest deploy log https://app.netlify.com/projects/biongff-vizarr/deploys/69eb4a7f12870c0008e9c4cb
😎 Deploy Preview https://deploy-preview-65--biongff-vizarr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@davehorsfall
Copy link
Copy Markdown
Collaborator

@AlexSurtees, can you please share the data/config you've been testing with?

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
viewer/src/io.ts 93.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dannda
Copy link
Copy Markdown
Collaborator

dannda commented Apr 24, 2026

can be tested with
?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.5/idr0062A/6001240_labels.zarr&anndata=https://storage.googleapis.com/haniffalab/test/zarr/6001240_labels-anndata.zarr

@LucaAnce
Copy link
Copy Markdown

Hi all! I am trying out the plugin testing the integration with Fractal features. I tested the compatibility with Fractal's Anndata backend for tables and it seems to work nicely for the most part!

The only problem I found was when selecting 'Numerical' type of Observations sometimes it causes the entire viewer to crash. This happens also when testing with the suggested data (?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.5/idr0062A/6001240_labels.zarr&anndata=https://storage.googleapis.com/haniffalab/test/zarr/6001240_labels-anndata.zarr) and selecting 'boolean' as the numerical observation to display it crashes with this error:
Uncaught TypeError: Cannot read properties of undefined (reading 'toFixed') at Legend (Legend.jsx:19:43)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants