Improve: Call target directly from unsafe_ifunc macro whenever possible.#165
Open
Sewer56 wants to merge 1 commit into
Open
Improve: Call target directly from unsafe_ifunc macro whenever possible.#165Sewer56 wants to merge 1 commit into
Sewer56 wants to merge 1 commit into
Conversation
03f1afb to
da7bef6
Compare
Author
|
CI Failure is not caused by this commit. This Actions Run Was ran with commit reverted, i.e. using code from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example based on discussion from:
This is just an example of the sort of improvement/change I had in mind:
Before:
RUSTFLAGS="-C target-cpu=x86-64-v3" cargo bench:After, with
no_std:Test is more than just use of memchr; it's on a real scenario involving memchr.
So this isn't a '2%' improvement, raw improvement is closer to '4%'.
For more details see: