[POC] feat: memchr-n#208
Draft
hsqStephenZhang wants to merge 1 commit into
Draft
Conversation
Author
|
if we wrap |
Author
|
@BurntSushi Would you like to take a brief look? Do you think this approach is feasible? If so, I could fix the Ci problems and go on work on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR about?
Implement shufti table based approach mentioned in #206 to support memchr-N (N could be arbitrary usize as long as shufti algo allows)
Background
see #206.
Implementation
shuffle_bytesandshift_8bit_lane_rightmethods fromaho_corasick.memchrn_iter, MemchrNpublic APIThis is still experimental, and it adds many overhead for maintenance. Perhaps a better approach is to create a separate crate named
memchr-nto support this feature.The purpose of this PR(now) is mainly for discussion since its quite a big change. Comments are welcomed. (But don't get trapped in current code style)