Fix minor UB flagged by miri#215
Open
Shnatsel wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed UB in the generic packed-pair finder when the safe
Finder::findAPI is called with a search-time needle longer than the haystack.Although callers are documented to pass the same needle used at construction time, this is still a safe API. A mismatched longer needle could make
find_in_chunkevaluateend.sub(needle.len()), creating a pointer before the start of the haystack allocation. That pointer was only used for comparison, not dereferenced, so ASan does not catch it, but Miri reports it as UB.The fix checks the remaining byte length from the candidate pointer to
endbefore forming any pointer derived fromend. If the search-time needle cannot fit, the function now returnsNonewithout invalid pointer arithmetic. This is verified with a Miri regression test.