Widen Symbolics compat to include v7 (blocked by SymbolicTracingUtils)#94
Open
Widen Symbolics compat to include v7 (blocked by SymbolicTracingUtils)#94
Conversation
Add Symbolics v7 to the [compat] bound in preparation for the upgrade. Currently, SymbolicTracingUtils v0.1.3 constrains Symbolics to v4/5/6, so the resolver will continue installing Symbolics v6 until that upstream dependency is updated. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widens the
Symbolicscompat bound from"6.51.0"to"6.51.0, 7"inProject.tomlto prepare for Symbolics.jl v7. This addresses CompatHelper PR #51.Status: Blocked — Symbolics v7 cannot actually be installed yet. See investigation below.
Changes
Project.toml: UpdatedSymbolicscompat from"6.51.0"to"6.51.0, 7"Investigation Findings
Blocker: SymbolicTracingUtils v0.1.3
The Pkg resolver cannot install Symbolics v7 because
SymbolicTracingUtils v0.1.3declares:This is the only released version of SymbolicTracingUtils, and it has no v7 compat. The dependency chain is:
Upstream PR exists: JuliaGameTheoreticPlanning/SymbolicTracingUtils.jl#5 — a CompatHelper PR to bump compat to
"4,5,6,7". It is open but untested (no CI checks, auto-generated).Transitive version pins
With Symbolics held at v6, these are also held back:
SymbolicUtils v3.32.0(v7 requires SymbolicUtils v4)SymbolicLimits v0.2.3(held by SymbolicUtils constraint)SciMLOperators v0.3.13(held by SciMLBase and SymbolicTracingUtils)Symbolics v7 Breaking Changes Analysis
When SymbolicTracingUtils is eventually updated, these are the key v7 changes relevant to our codebase:
New
Constvariant:Numnow always wrapsBasicSymbolic— constants becomeConst{T}(val). Code usingSymbolics.Num.(...)for broadcasting conversion (ournonlinear_kkt.jl:318,328) may need adjustment.symtypemoved from type parameter to field:BasicSymbolic{T}whereTis nowvartype(notsymtype). Our code usesNumtype annotations (Dict{Int, Vector{Symbolics.Num}}) which should still work sinceNumremains.SymbolicUtils v3 → v4: Internal representation uses Moshi.jl instead of Unityper.
arguments()now returns read-only arrays.Add/Mulmerged intoAddMul: Pattern matching internals changed, but we don't access these directly.Expression simplification changes:
(a/b)^cauto-rewrites toa^c/b^cinSymRealmode, which could affect numerical results in KKT condition simplification.APIs we use that are UNCHANGED:
@variables,Symbolics.gradient,Symbolics.jacobian,Symbolics.get_variables,build_function(via SymbolicTracingUtils).Our Symbolics API Usage (for future reference)
@variablesSymbolics.gradientSymbolics.jacobianSymbolics.get_variablesSymbolics.Numtype annotationsNumstill exists, likely safeSymbolics.Num.(x)broadcastingConsteltype()with symbolic vectorsNuminternals differSymbolicTracingUtils.build_functionTesting
Recommendation
Do NOT merge this PR yet. The compat bound widening is harmless but premature — Symbolics v7 cannot be installed. The recommended path forward:
Symbolics = "4,5,6,7"Pkg.update(), and test with actual Symbolics v7Symbolics.Num.(...)broadcasting innonlinear_kkt.jl, possible test tolerance adjustments due to expression simplification changesAlternatively, if urgency is high, consider forking SymbolicTracingUtils temporarily or using
Pkg.develop()with the compat PR branch.Changelog