Firefly-1974: support Rubin v2 mask header format#1932
Merged
Conversation
Contributor
|
nice! this is really cool. (when can we get it this nice for spherex? i'm betting they'd have to make changes to their data which will be ...tough.) |
kpuriIpac
approved these changes
Apr 9, 2026
Contributor
kpuriIpac
left a comment
There was a problem hiding this comment.
Looks great! One small typo bug I found in code that I pointed out below.
One pre-existing bug I found, that may be easy to fix here:
- I accidentally went to
Tools->Layers->Add Mask to Image - do this (for either one of the fits files) and you'll see a console error, then go to
Drawing Layers-> you may see something likebit # 1 - loading, turn this off and it stays turned off with the console error. - I think fix is simple in OverlayPlotView.js:
plot.cubeCtx?.cubePlane(line 72)
src/firefly/java/edu/caltech/ipac/visualize/plot/plotdata/FitsReadUtil.java
Outdated
Show resolved
Hide resolved
- includes reponse to feedback
f60009d to
3233897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-1974: support rubin v2 mask header format
Support mask in the FITS header form
Testing
How to show mask