Skip to content

Firefly-1974: support Rubin v2 mask header format#1932

Merged
robyww merged 1 commit intodevfrom
FIREFLY-1974-mask
Apr 10, 2026
Merged

Firefly-1974: support Rubin v2 mask header format#1932
robyww merged 1 commit intodevfrom
FIREFLY-1974-mask

Conversation

@robyww
Copy link
Copy Markdown
Contributor

@robyww robyww commented Apr 7, 2026

Firefly-1974: support rubin v2 mask header format

Support mask in the FITS header form

MSKN0001= 'BAD     '
MSKM0001=        1
MSKD0001= 'Bad pixel in the instrument, including bad amplifiers.'
MSKN0002= 'COSMIC_RAY'
MSKM0002=        2 
MSKD0002= 'A cosmic ray affected this pixel.'                             
etc

Testing

How to show mask

  • upload the image from the url and then choose only the first HDU, the choose load image
  • go to the drawing layers and click enable to show the mask layers
  • enable some or all of the layers
  • The new mask format allows for a description of the mask that will show up in the layer

@robyww robyww added this to the 2026.1 milestone Apr 7, 2026
@robyww robyww self-assigned this Apr 7, 2026
@robyww robyww added the bug label Apr 7, 2026
@robyww robyww requested review from gpdf and kpuriIpac April 7, 2026 16:50
@robyww robyww marked this pull request as ready for review April 7, 2026 16:51
@robyww robyww added enhancement Image FITS images and removed bug labels Apr 7, 2026
@lrebull
Copy link
Copy Markdown
Contributor

lrebull commented Apr 9, 2026

nice! this is really cool. (when can we get it this nice for spherex? i'm betting they'd have to make changes to their data which will be ...tough.)

Copy link
Copy Markdown
Contributor

@kpuriIpac kpuriIpac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One small typo bug I found in code that I pointed out below.

One pre-existing bug I found, that may be easy to fix here:

  • I accidentally went to Tools -> Layers -> Add Mask to Image
  • do this (for either one of the fits files) and you'll see a console error, then go to Drawing Layers -> you may see something like bit # 1 - loading, turn this off and it stays turned off with the console error.
  • I think fix is simple in OverlayPlotView.js: plot.cubeCtx?.cubePlane (line 72)

@robyww robyww force-pushed the FIREFLY-1974-mask branch from f60009d to 3233897 Compare April 10, 2026 15:01
@robyww robyww merged commit 252b291 into dev Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants