Add __PIO_DONT_SET_CLOCK_SOURCE__ option#13
Open
hoverboardhavoc wants to merge 1 commit intoCommunityGD32Cores:mainfrom
Open
Add __PIO_DONT_SET_CLOCK_SOURCE__ option#13hoverboardhavoc wants to merge 1 commit intoCommunityGD32Cores:mainfrom
hoverboardhavoc wants to merge 1 commit intoCommunityGD32Cores:mainfrom
Conversation
Introduce a `__PIO_DONT_SET_CLOCK_SOURCE__` macro to allow users to override the default clock-source selection without touching the SPL library itself. Fixes CommunityGD32Cores#4 Copied from CommunityGD32Cores/ArduinoCore-GD32@86e0ac7
hoverboardhavoc
force-pushed
the
hoverboardhavoc/add__PIO_DONT_SET_CLOCK_SOURCE__
branch
from
a247607 to
8849cb2
Compare
Author
|
Please double check that I've fixed every variant! |
hoverboardhavoc
added a commit
to hoverboardhavoc/Hoverboard-Firmware-Hack-Gen2.x-GD32
that referenced
this pull request
May 5, 2025
The PlatformIO build was unintentionally running at the wrong clock source, causing motors to emit a metallic noise. Use __SYSTEM_CLOCK_72M_PLL_IRC8M_DIV2 (as used by the Keil build) This required a little change to gd32-pio-spl-package to add support for __PIO_DONT_SET_CLOCK_SOURCE__ See CommunityGD32Cores/gd32-pio-spl-package#13
|
Yes, please accept this pull request so my hoverboard firmware can rely on the main branch here :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
__PIO_DONT_SET_CLOCK_SOURCE__macro to allow users to override the default clock-source selection without touching the SPL library itself.Fixes #4
Copied from CommunityGD32Cores/ArduinoCore-GD32@86e0ac7