Skip to content

fix(contracts): optimize gas usage in Attestation struct #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
airope wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(contracts): optimize gas usage in Attestation struct #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions contracts/src/AttestationRegistry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,20 +119,20 @@ contract AttestationRegistry is OwnableUpgradeable {
bytes32 id = generateAttestationId(attestationIdCounter);
assert(id != 0x0 && !isRegistered(id));
// Create attestation
attestations[id] = Attestation(
id,
attestationPayload.schemaId,
bytes32(0),
attester,
msg.sender,
uint64(block.timestamp),
attestationPayload.expirationDate,
0,
version,
false,
attestationPayload.subject,
attestationPayload.attestationData
);
attestations[id] = Attestation({
attestationId: id,
schemaId: attestationPayload.schemaId,
replacedBy: bytes32(0),
attester: attester,
portal: msg.sender,
attestedDate: uint64(block.timestamp),
expirationDate: attestationPayload.expirationDate,
revocationDate: 0,
version: version,
revoked: false,
subject: attestationPayload.subject,
attestationData: attestationPayload.attestationData
});
emit AttestationRegistered(id);
}

Expand All @@ -154,20 +154,20 @@ contract AttestationRegistry is OwnableUpgradeable {
bytes32 id = generateAttestationId(attestationIdCounter);
assert(id != 0x0 && !isRegistered(id));
// Create attestation
attestations[id] = Attestation(
id,
attestationsPayloads[i].schemaId,
bytes32(0),
msg.sender,
portal,
uint64(block.timestamp),
attestationsPayloads[i].expirationDate,
0,
version,
false,
attestationsPayloads[i].subject,
attestationsPayloads[i].attestationData
);
attestations[id] = Attestation({
attestationId: id,
schemaId: attestationsPayloads[i].schemaId,
replacedBy: bytes32(0),
attester: msg.sender,
portal: portal,
attestedDate: uint64(block.timestamp),
expirationDate: attestationsPayloads[i].expirationDate,
revocationDate: 0,
version: version,
revoked: false,
subject: attestationsPayloads[i].subject,
attestationData: attestationsPayloads[i].attestationData
});
emit AttestationRegistered(id);
}
}
Expand Down
28 changes: 14 additions & 14 deletions contracts/src/stdlib/IndexerModuleV2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,19 +190,19 @@ contract IndexerModuleV2 is AbstractModuleV2 {
address portal
) internal view returns (Attestation memory) {
return
Attestation(
attestationRegistry.getNextAttestationId(),
attestationPayload.schemaId,
bytes32(0),
attester,
portal,
uint64(block.timestamp),
attestationPayload.expirationDate,
0,
attestationRegistry.getVersionNumber(),
false,
attestationPayload.subject,
attestationPayload.attestationData
);
Attestation({
attestationId: attestationRegistry.getNextAttestationId(),
schemaId: attestationPayload.schemaId,
replacedBy: bytes32(0),
attester: attester,
portal: portal,
attestedDate: uint64(block.timestamp),
expirationDate: attestationPayload.expirationDate,
revocationDate: 0,
version: attestationRegistry.getVersionNumber(),
revoked: false,
subject: attestationPayload.subject,
attestationData: attestationPayload.attestationData
});
}
}
Loading