chore(contracts): upgrade Solhint to 6#1064
Merged
Conversation
✅ Deploy Preview for verax-tutorial ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1064 +/- ##
=======================================
Coverage 51.41% 51.41%
=======================================
Files 26 26
Lines 776 776
Branches 111 111
=======================================
Hits 399 399
Misses 377 377 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
VGau
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use-natspecin the shared Solhint config so the Solhint 6 upgrade does not flood CI with documentation-completeness warnings from existing contracts/testsValidation
Lintrun 24895284932, job 72898272223 completed successfully and was not skippedsize-contractsinitially hit an external Hardhat compiler download timeout and passed on rerunWarning surface
Solhint 6 substantially increased the warning output because
solhint:recommendednow surfacesuse-natspecdocumentation checks across contracts, tests, mocks, and examples.Before tuning, the PR had 1131 Solhint warnings total:
contracts: 902 warnings, including 818 fromuse-natspecexamples: 229 warnings, including 208 fromuse-natspecAfter disabling only
use-natspec, local Solhint output is back to a readable level while preserving the code-oriented warnings:contracts: 84 warnings, 0 errorsexamples: 21 warnings, 0 errorsThe warnings shown in the linked
build-contractsjob are Foundry/Solidity compiler lint notes, not Solhint output. They are identical to the latest successfuldevContracts run and are not introduced by this Solhint PR.Closes #1050