Skip to content

chore(contracts): upgrade Solhint to 6#1064

Merged
alainncls merged 2 commits intodevfrom
codex/deps-solhint-6
Apr 24, 2026
Merged

chore(contracts): upgrade Solhint to 6#1064
alainncls merged 2 commits intodevfrom
codex/deps-solhint-6

Conversation

@alainncls
Copy link
Copy Markdown
Collaborator

@alainncls alainncls commented Apr 24, 2026

Summary

  • upgrade the Solidity catalog solhint entry from 5.2.0 to 6.2.1
  • remove the solhint>ajv override that was only needed for solhint 5.x
  • disable use-natspec in the shared Solhint config so the Solhint 6 upgrade does not flood CI with documentation-completeness warnings from existing contracts/tests
  • refresh the pnpm lockfile

Validation

  • pnpm install
  • pnpm --filter @verax-attestation-registry/verax-contracts --filter @verax-attestation-registry/verax-examples -r run lint
  • pnpm --filter @verax-attestation-registry/verax-contracts --filter @verax-attestation-registry/verax-examples -r run build
  • pre-commit hook ran prettier, full lint, and contracts forge test successfully
  • GitHub Actions Lint run 24895284932, job 72898272223 completed successfully and was not skipped
  • GitHub Actions PR checks are green; size-contracts initially hit an external Hardhat compiler download timeout and passed on rerun

Warning surface

Solhint 6 substantially increased the warning output because solhint:recommended now surfaces use-natspec documentation checks across contracts, tests, mocks, and examples.

Before tuning, the PR had 1131 Solhint warnings total:

  • contracts: 902 warnings, including 818 from use-natspec
  • examples: 229 warnings, including 208 from use-natspec

After disabling only use-natspec, local Solhint output is back to a readable level while preserving the code-oriented warnings:

  • contracts: 84 warnings, 0 errors
  • examples: 21 warnings, 0 errors

The warnings shown in the linked build-contracts job are Foundry/Solidity compiler lint notes, not Solhint output. They are identical to the latest successful dev Contracts run and are not introduced by this Solhint PR.

Closes #1050

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for verax-tutorial ready!

Name Link
🔨 Latest commit 681edd2
🔍 Latest deploy log https://app.netlify.com/projects/verax-tutorial/deploys/69eb8088e1a5950008f6d063
😎 Deploy Preview https://deploy-preview-1064--verax-tutorial.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 24, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​solhint@​5.2.0 ⏵ 6.2.19710010092 +3100 +31

View full report

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.41%. Comparing base (958483c) to head (681edd2).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1064   +/-   ##
=======================================
  Coverage   51.41%   51.41%           
=======================================
  Files          26       26           
  Lines         776      776           
  Branches      111      111           
=======================================
  Hits          399      399           
  Misses        377      377           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alainncls alainncls marked this pull request as ready for review April 24, 2026 12:44
@alainncls alainncls self-assigned this Apr 24, 2026
@alainncls alainncls changed the title chore(deps): upgrade Solhint to v6 chore(contracts): upgrade Solhint to 6 Apr 24, 2026
@alainncls alainncls merged commit 32c3323 into dev Apr 24, 2026
31 of 32 checks passed
@alainncls alainncls deleted the codex/deps-solhint-6 branch April 24, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(deps): migrate Solidity linting to Solhint 6

3 participants