feat(attestation): add support for individual attesters in bulk attest and replace functions#994
Open
jukeboxhero123 wants to merge 1 commit intoConsensys:devfrom
Conversation
…t and replace functions
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modifies the Abstract Portal contract so that the
getAttester()function takes in the attestation and validation payloads as parameters. This adds more flexibility allowing for signature-based patterns much cleaner. Additionally, this PR modifies howModulesRegistryandAttestationRegistryhandle bulk attests with a new function that takes in an array of attesters. Backwards compatibility is maintained.Related to the discussion in Verax Discord channel:
https://discord.com/channels/1133748504171393167/1133748504620179578/1443696251861209159
Type of change
Check list
Note
Adds per-attestation attester support across bulk flows and updates attester resolution in portals.
AttestationRegistry: newbulkAttestWithAttestersandbulkReplaceWithAttesters; validates array lengths; existing bulk methods retained.ModuleRegistry: newbulkRunModulesV2WithAttestersto pass attesters per payload; addsArrayLengthMismatcherror.AbstractPortalV2:getAttesternow takesattestationPayloadandvalidationPayloads; single and bulk operations compute attesters and call new registry methods;_onReplaceupdated to receive computedattester.Written by Cursor Bugbot for commit 0f93c10. This will update automatically on new commits. Configure here.