Skip to content

feat(attestation): add support for individual attesters in bulk attest and replace functions#994

Open
jukeboxhero123 wants to merge 1 commit intoConsensys:devfrom
jukeboxhero123:feature/add-payloads-to-get-attester
Open

feat(attestation): add support for individual attesters in bulk attest and replace functions#994
jukeboxhero123 wants to merge 1 commit intoConsensys:devfrom
jukeboxhero123:feature/add-payloads-to-get-attester

Conversation

@jukeboxhero123
Copy link
Copy Markdown

@jukeboxhero123 jukeboxhero123 commented Dec 8, 2025

What does this PR do?

Modifies the Abstract Portal contract so that the getAttester() function takes in the attestation and validation payloads as parameters. This adds more flexibility allowing for signature-based patterns much cleaner. Additionally, this PR modifies how ModulesRegistry and AttestationRegistry handle bulk attests with a new function that takes in an array of attesters. Backwards compatibility is maintained.

Related to the discussion in Verax Discord channel:
https://discord.com/channels/1133748504171393167/1133748504620179578/1443696251861209159

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • My contribution follows the project's guidelines
  • I have made corresponding changes to the documentation
  • Unit tests for any smart contract change
  • Contracts and functions are documented

Note

Adds per-attestation attester support across bulk flows and updates attester resolution in portals.

  • Registries:
    • AttestationRegistry: new bulkAttestWithAttesters and bulkReplaceWithAttesters; validates array lengths; existing bulk methods retained.
    • ModuleRegistry: new bulkRunModulesV2WithAttesters to pass attesters per payload; adds ArrayLengthMismatch error.
  • Portal:
    • AbstractPortalV2: getAttester now takes attestationPayload and validationPayloads; single and bulk operations compute attesters and call new registry methods; _onReplace updated to receive computed attester.
  • Tests/Mocks:
    • Mocks extended with new bulk-per-attester methods and events for compatibility.

Written by Cursor Bugbot for commit 0f93c10. This will update automatically on new commits. Configure here.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Dec 8, 2025

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Dec 8, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alainncls alainncls closed this Jan 14, 2026
@alainncls alainncls reopened this Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants