[DYN-8338] Move Auto-Complete Marker Triggering to ViewModel Instead of Codebehind

[johnpierson]

Purpose

This PR builds upon a previous PR (#15947).

The Node AutoComplete marker now shows on ports with no wires when the node is selected.

Additionally, I changed the PreviewMouseDown to PreviewMouseLeftButtonDown because middle click was firing off the DNA command. 🙈

Related to DYN-8338

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated
• This PR contains no files larger than 50 MB

Release Notes

• Introduction of a new in canvas marker (outside the port). This new marker, the Node Autocomplete Marker, allows for launching of the node autocomplete service.

Reviewers

@QilongTang @BogdanZavu @chubakueno @Jingyi-Wen

FYIs

@achintyabhat @Amoursol

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8338

[QilongTang]

Do you think the delay would be something we can define on XML layer? @johnpierson @BogdanZavu Just curious

[johnpierson]

I am not too sure but can research. Would be keen to your thoughts @BogdanZavu

[BogdanZavu]

In the xaml perhaps we could have some animation that comes with a delay but I'm a little worried about introducing too much complexity and issues related to animation that we might not see right away.

            <EventTrigger RoutedEvent="MouseLeave">
                <BeginStoryboard>
                    <Storyboard>
                        <DoubleAnimation Storyboard.TargetName="InfoPanel"
                                         Storyboard.TargetProperty="Opacity"
                                         To="0"
                                         BeginTime="0:0:1"  <!-- delay -->
                                         Duration="0:0:0.2" />
                    </Storyboard>
                </BeginStoryboard>
            </EventTrigger>

Or maybe we can just improve what we have a little bit and that should be enough without using a delay ?!
We could have the marker ON based on focus or on focus and mouse enter.
So if the node if selected/blue - we don't hide the marker on mouse leave - we will hide it on lost focus event.
And we continue to hide it on mouse leave if the control does not have focus.

[johnpierson]

I was worried that if multiple nodes have focus it will try to show the markers for all of those nodes, but maybe that is ok?

[johnpierson]

I really like the animation, because it just feels so clean. But if that could be an issue, that does worry me

[BogdanZavu]

Yeah, imo I think it's ok/expected to show the marker for what's in the selection. I think we're inline with other controls that appear on selection.

[johnpierson]

I think that makes sense to me. So effectively tie it to the blue selection border almost?

[BogdanZavu]

I think we should tie it to the focus event if possible. The blue border control behavior might change in the future.

[QilongTang]

LGTM but I am curious if there can be a cleaner way per my comment

[BogdanZavu]

LGTM but I am curious if there can be a cleaner way per my comment

Yes, same LGTM!

[johnpierson]

Cool. Let me look into that

…

On Mon, Mar 24, 2025 at 12:56 PM Bogdan Zavu ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs <#15969 (comment)>: > @@ -601,8 +604,16 @@ private void OnNodeViewMouseLeave(object sender, MouseEventArgs e) ViewModel.ZIndex = oldZIndex; //hide the node autocomplete marker if mouse leaves the node - TryHideAutoCompleteMaker(); - + if (IsAutoCompleteMarkerDisabled()) return; + if (Mouse.Captured is DragCanvas) + { + Dispatcher.BeginInvoke(new Action(TryHideAutoCompleteMaker), DispatcherPriority.Loaded); + } + else + { + Dispatcher.DelayInvoke(autoCompleteMarkerDelay, TryHideAutoCompleteMaker); I think we should tie it to the focus event if possible. The blue border control behavior might change in the future. — Reply to this email directly, view it on GitHub <#15969 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADYD5VAPWIB4VASLXETWQE32WBIPNAVCNFSM6AAAAABZU2GCMOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMJRGQYDQOJZGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[johnpierson]

Alrighty @BogdanZavu and @QilongTang - I made the changes to allow it to work with selection instead of hover or mouse events. It seems to be working real nice on my testing. So if you could re-review.

it working while selected actually mirrors more how I would want it to work as a user. (Eg. the connections on Miro board notes)

[QilongTang]

Waiting for checks to finish before merging

[johnpierson]

Once we get this all sorted we’re going to need to see about getting this in the RC. https://github.com/DynamoDS/Dynamo/tree/RC3.5.0_master

[QilongTang]

Once we get this all sorted we’re going to need to see about getting this in the RC. https://github.com/DynamoDS/Dynamo/tree/RC3.5.0_master

yeah, cherry-pick shouldn't be a problem considering this is an improvement instead of new request