Cherry-Pick-Html localization to master (4 commits)#15978
Merged
QilongTang merged 13 commits intoDynamoDS:masterfrom Mar 25, 2025
Merged
Cherry-Pick-Html localization to master (4 commits)#15978QilongTang merged 13 commits intoDynamoDS:masterfrom
QilongTang merged 13 commits intoDynamoDS:masterfrom
Conversation
adding missing </Target>
Removing extra PackageReference to DynamoVisualProgramming
Contributor
|
@RobertGlobant20 I made a try to fix the build, let me know if it's the right fix or not |
…rtGlobant20/Dynamo into html_localization_to_master
I'm removing the localized resx files as embedded resources from DynamoCoreWpf (due that are missing) and also after the merge there was an extra </Target> which was removed.
re-triggering the build/jobs
Contributor
|
@RobertGlobant20 Curious, still in the process of making more changes? |
Contributor
Author
No, I'm done with the changes, now all jobs/checks passed. |
QilongTang
approved these changes
Mar 25, 2025
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM, let's give it a try
RobertGlobant20
added a commit
to RobertGlobant20/Dynamo
that referenced
this pull request
Mar 26, 2025
Co-authored-by: Aaron (Qilong) <aaron.tang@autodesk.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Cherry-Pick-Html localization to master (4 commits)
In this PR there is one xml that doesn't exist yet DSCoreNodes.xml, the file will exist when the next PR is merged to master #15977
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Cherry-Pick-Html localization to master (4 commits)
Reviewers
@QilongTang
FYIs
@ZbynekHanak-RWS