DYN-8606 : move flyout to extension#16101
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8606
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with a couple comments, so looks like all the controls can be moved correctly while the NodeAutoComplete SearchViewModel for now need to stay in Core?
So yes, the old autocomplete without any of the cluster stuff will stay in Core and we declare all public api related to it obsolete. |
QilongTang
left a comment
There was a problem hiding this comment.
LGTM, while Washington, we have a problem :) There is some tech debt that @DynamoDS/dynamo did not figure out clearly how view extension unit tests can be written and run correctly if living outside of this repo. If we keep things this way, it maybe easier but if we want to use a dedicated repo, there will be some difficulty there. Let's discuss at standup
Purpose
Moving AutoComplete bar flyout to NodeAutoCompleteViewExtension project.
All new development for cluster AutoComplete will be done as part of the extension.
In the future we might consider to have the extension in it's own separate repo, make a package etc.. but it is too early for that.
Still work in progress but so far it appears to be working as expected.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/synapse