Skip to content

DYN-8606 : move flyout to extension#16101

Merged
BogdanZavu merged 3 commits intoDynamoDS:masterfrom
BogdanZavu:DYN-8606
Apr 8, 2025
Merged

DYN-8606 : move flyout to extension#16101
BogdanZavu merged 3 commits intoDynamoDS:masterfrom
BogdanZavu:DYN-8606

Conversation

@BogdanZavu
Copy link
Copy Markdown
Contributor

@BogdanZavu BogdanZavu commented Apr 4, 2025

Purpose

Moving AutoComplete bar flyout to NodeAutoCompleteViewExtension project.
All new development for cluster AutoComplete will be done as part of the extension.
In the future we might consider to have the extension in it's own separate repo, make a package etc.. but it is too early for that.
Still work in progress but so far it appears to be working as expected.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Reviewers

@DynamoDS/synapse

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8606

@BogdanZavu BogdanZavu added the WIP label Apr 4, 2025
Comment thread src/DynamoCoreWpf/Views/Core/WorkspaceView.xaml.cs
Comment thread src/NodeAutoCompleteViewExtension/NodeAutoCompleteViewExtension.cs Outdated
Copy link
Copy Markdown
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple comments, so looks like all the controls can be moved correctly while the NodeAutoComplete SearchViewModel for now need to stay in Core?

@BogdanZavu
Copy link
Copy Markdown
Contributor Author

BogdanZavu commented Apr 7, 2025

LGTM with a couple comments, so looks like all the controls can be moved correctly while the NodeAutoComplete SearchViewModel for now need to stay in Core?

So yes, the old autocomplete without any of the cluster stuff will stay in Core and we declare all public api related to it obsolete.
At some point in the future we will remove it completely once the flyout takes over.

@BogdanZavu BogdanZavu removed the WIP label Apr 7, 2025
Copy link
Copy Markdown
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, while Washington, we have a problem :) There is some tech debt that @DynamoDS/dynamo did not figure out clearly how view extension unit tests can be written and run correctly if living outside of this repo. If we keep things this way, it maybe easier but if we want to use a dedicated repo, there will be some difficulty there. Let's discuss at standup

@BogdanZavu BogdanZavu merged commit cbac04b into DynamoDS:master Apr 8, 2025
28 of 32 checks passed
@BogdanZavu BogdanZavu deleted the DYN-8606 branch April 8, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants