[DYN-8648] Curve Mapper node gets into spurious sticky warning state#16115
Closed
ivaylo-matov wants to merge 3 commits intoDynamoDS:masterfrom
Closed
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8648
zeusongit
reviewed
Apr 7, 2025
| { | ||
| Warning(Properties.Resources.CurveMapperWarningMessage, isPersistent: true); | ||
| } | ||
| else if (!anyInvalid) |
Contributor
There was a problem hiding this comment.
Can you add a comment here on why we need 2 different valid checks, and what are they addressing.
zeusongit
reviewed
Apr 7, 2025
| VMDataBridge.DataBridge.GenerateBridgeDataAst(GUID.ToString(), AstFactory.BuildExprList(inputValues)) | ||
| ); | ||
|
|
||
| if (!InPorts[0].IsConnected || !InPorts[1].IsConnected || !InPorts[2].IsConnected || !InPorts[3].IsConnected || !InPorts[4].IsConnected) |
Contributor
There was a problem hiding this comment.
Can we use: if(InPorts.Any(x => !x.IsConnected))?
Collaborator
|
This needs more testing and will be part of next release. |
…ous-sticky-warning-state
Contributor
Author
|
This is outdated based on the latest discussion. Please refer to the updated proposal in #16141 |
Collaborator
|
Closing this for the same reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
To fix this case: https://jira.autodesk.com/browse/DYN-8648
Updating the warning/error message on the CurveMapper node based on valid or invalid input.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Updating the warning/error message on the CurveMapper node based on valid or invalid input.
Reviewers
@reddyashish
@zeusongit
FYIs
@achintyabhat
@dnenov