Skip to content

DYN-8577 Invalid Locale DynamoSettings Bug#16161

Merged
zeusongit merged 1 commit intoDynamoDS:masterfrom
RobertGlobant20:DYN-8577-Invalid-Locale-DynamoSettings-Bug
Apr 25, 2025
Merged

DYN-8577 Invalid Locale DynamoSettings Bug#16161
zeusongit merged 1 commit intoDynamoDS:masterfrom
RobertGlobant20:DYN-8577-Invalid-Locale-DynamoSettings-Bug

Conversation

@RobertGlobant20
Copy link
Copy Markdown
Contributor

Purpose

Fixing locale bug reported during testing when having <Locale>xyz</Locale> in DynamoSettings.xml
When xyz in DynamoSettings.xml and opening the Package Manager, the help was appearing in a different language so with this fix now when opening the help will appear in the same language than the Language Dropdown in Preferences

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixing locale bug reported during testing when having <Locale>xyz</Locale> in DynamoSettings.xml

Reviewers

@zeusongit

FYIs

@jnealb

When <Locale>xyz</Locale> in DynamoSettings.xml and opening the Package Manager, the help was appearing in a different language so with this fix now when opening the help will appear in the same language than the Language Dropdown in Preferences
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8577

@RobertGlobant20
Copy link
Copy Markdown
Contributor Author

GIF showing the expected behavior.
explorer_pldciMeqZ7

@RobertGlobant20
Copy link
Copy Markdown
Contributor Author

@zeusongit any other comment in this PR?

@zeusongit zeusongit merged commit d051433 into DynamoDS:master Apr 25, 2025
24 of 25 checks passed
@zeusongit
Copy link
Copy Markdown
Contributor

@zeusongit any other comment in this PR?

All good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants