DYN-8646 - Expand AutoComplete (Node Type Match) to Provide More Accurate Results

[johnpierson]

Purpose

Currently node type match fails to find a match if the input port's data type is not explicitly one of the predefined. Eg. a node's input can be List<string>, resulting in the suggestions in the Before GIF below. By switching to string.contains instead of equals, we get results that closer match expectations.

Behavior Before:

Behavior After:

Note: while this is not a perfect fix, this does help at least work toward being a more correct suggestion, rather than defaulting to all of the default inputs. Node type match isn't the highest priority, but we wanted to give it a little attention. I do think that we can expand this further as well because NodeModels still have failures using node type match. Eg. Curve Mapper.

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated
• This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@DynamoDS/synapse

FYIs

@Jingyi-Wen @achintyabhat @jnealb @mjkkirschner

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8646

[aparajit-pratap]

For ports that accept lists of ints, doubles, strings, etc., do we also try to match them with nodes returning the exact types - lists of ints, doubles, strings, respectively?

[johnpierson]

For ports that accept lists of ints, doubles, strings, etc., do we also try to match them with nodes returning the exact types - lists of ints, doubles, strings, respectively?

At this time (before this PR), all we do is present the defaults.

• string
• numbers slider
• integer slider
• number
• boolean

So no real logic, just defaults in the default order.