fix: 0.15.2 failing tests + reliance on deprecated APIs#11
Open
mloujapero726381837 wants to merge 1 commit intoEzequielRamis:0.15.xfrom
Open
fix: 0.15.2 failing tests + reliance on deprecated APIs#11mloujapero726381837 wants to merge 1 commit intoEzequielRamis:0.15.xfrom
mloujapero726381837 wants to merge 1 commit intoEzequielRamis:0.15.xfrom
Conversation
Author
|
For reference, I am working on a 0.16 port, including all tools and bench, which is partially complete with a few benchmarks and tools left standing for the short while. If there is any interest in merging, I would be happy to push a PR over, else I will just maintain it as a fork. |
Owner
|
Hey, sorry for the delay... I’ve been quite busy. I’d be happy to review your PR for 0.16. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the 0.15.x branch relies on deprecated or missing APIs, such as
file.reader().any(). Most of the work in this commit is replacingreader().any()with&reader.interface.Currently, this is not a complete fix to all deprecated API usage as, for example, some files in
tools/andbench/usestd.io.bufferedReader, all it does is make the library usable on 0.15.2.Targets 0.15.2, but backports the takeDelimiterExclusive regression fix to 0.15.1