Skip to content

[BREAKING][MISC] Set default constraint solver tolerance based on floating-point precision.#2713

Merged
duburcqa merged 2 commits intoGenesis-Embodied-AI:mainfrom
duburcqa:relax_constraint_solver_tol
Apr 16, 2026
Merged

[BREAKING][MISC] Set default constraint solver tolerance based on floating-point precision.#2713
duburcqa merged 2 commits intoGenesis-Embodied-AI:mainfrom
duburcqa:relax_constraint_solver_tol

Conversation

@duburcqa
Copy link
Copy Markdown
Collaborator

Related to #2710

@duburcqa duburcqa requested a review from YilingQiao as a code owner April 15, 2026 08:58
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@duburcqa duburcqa marked this pull request as draft April 15, 2026 08:59
@github-actions
Copy link
Copy Markdown

⚠️ Abnormal Benchmark Result Detected ➡️ Report

Comment thread genesis/engine/solvers/rigid/rigid_solver.py
Comment thread genesis/engine/solvers/rigid/rigid_solver.py
Comment thread genesis/options/solvers.py
@duburcqa duburcqa closed this Apr 16, 2026
@duburcqa duburcqa deleted the relax_constraint_solver_tol branch April 16, 2026 08:16
@duburcqa duburcqa restored the relax_constraint_solver_tol branch April 16, 2026 08:39
@duburcqa duburcqa reopened this Apr 16, 2026
@github-actions
Copy link
Copy Markdown

⚠️ Abnormal Benchmark Result Detected ➡️ Report

@duburcqa duburcqa marked this pull request as ready for review April 16, 2026 18:13
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@duburcqa duburcqa force-pushed the relax_constraint_solver_tol branch from 2c79fc7 to a54b9a6 Compare April 16, 2026 18:19
@duburcqa duburcqa force-pushed the relax_constraint_solver_tol branch from a54b9a6 to fbaa8a2 Compare April 16, 2026 18:20
@duburcqa duburcqa merged commit c77ae90 into Genesis-Embodied-AI:main Apr 16, 2026
4 checks passed
@github-actions
Copy link
Copy Markdown

🔴 Benchmark Regression Detected ➡️ Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants