Build: update setuptools config and CI#241
Merged
MuellerSeb merged 21 commits intomainfrom Jun 13, 2022
Merged
Conversation
Member
Author
|
OpenMP support was never available in CI for macOS. There is also an open PR for clang/openmp support on macOS here: astropy/extension-helpers#42 We could wait for this PR to be merged and then we could install openmp with brew for macOS: - name: macos openmp install
uses: mstksg/get-package@v1
if: matrix.os == 'macos-latest'
with:
brew: libomp |
LSchueler
requested changes
Jun 9, 2022
Member
LSchueler
left a comment
There was a problem hiding this comment.
That's a nice improvement in the setup! A small fix in the toml-file and you're ready to merge this 👍
Member
Author
|
When this is implemented, we can even drop the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
setup.cfgcontent topyproject.toml(PEP 621)pyproject.tomlconfig with setuptools)src/based package structure (better for testing, building and structure)setup.py