Skip to content

fix(deps): update module k8s.io/klog to v2 - abandoned#184

Open
renovate-bot wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
renovate-bot:renovate/k8s.io-klog-2.x
Open

fix(deps): update module k8s.io/klog to v2 - abandoned#184
renovate-bot wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
renovate-bot:renovate/k8s.io-klog-2.x

Conversation

@renovate-bot
Copy link
Copy Markdown
Contributor

@renovate-bot renovate-bot commented Nov 24, 2025 •
edited
Loading

This PR contains the following updates:

Package Change Age Confidence
k8s.io/klog v1.0.0 → v2.130.1 age confidence

Release Notes

kubernetes/klog (k8s.io/klog)

v2.130.1: Prepare klog release for Kubernetes v1.31 (Take 2)

Compare Source

What's Changed

Full Changelog: kubernetes/klog@v2.130.0...v2.130.1

v2.130.0: Prepare klog release for Kubernetes v1.31 (Take 1)

Compare Source

What's Changed

New Contributors

Full Changelog: kubernetes/klog@v2.120.1...v2.130.0

v2.120.1: Prepare klog release for Kubernetes v1.30 (Take 2)

Compare Source

What's Changed

Full Changelog: kubernetes/klog@v2.120.0...v2.120.1

v2.120.0: Prepare klog release for Kubernetes v1.30 (Take 1)

Compare Source

What's Changed

New Contributors

Full Changelog: kubernetes/klog@v2.110.1...v2.120.0

v2.110.1: Prepare klog release for Kubernetes v1.29 (Take 1)

Compare Source

What's Changed

New Contributors

Full Changelog: kubernetes/klog@v2.100.1...v2.110.1

v2.100.1: Prepare klog release for Kubernetes v1.28 (Take 1)

Compare Source

What's Changed

New Contributors

Full Changelog: kubernetes/klog@v2.90.1...v2.100.1

v2.90.1: Prepare klog release for Kubernetes v1.27 (Take 2)

Compare Source

What's Changed

Full Changelog: kubernetes/klog@v2.90.0...v2.90.1

v2.90.0: Prepare klog release for Kubernetes v1.27 (Take 1)

Compare Source

What's Changed

Full Changelog: kubernetes/klog@v2.80.1...v2.90.0

There are some API differences from previous version
k8s.io/klog/v2/klogr contains incompatible changes:
 - klogger.Enabled: removed
 - klogger.Error: removed
 - klogger.Info: removed

k8s.io/klog/v2/test contains incompatible changes:
 - InitKlog: changed from func() to func(testing.TB) *flag.FlagSet

v2.80.1: Prepare klog release for Kubernetes v1.26 (Take 2)

Compare Source

What's Changed

Full Changelog: kubernetes/klog@v2.80.0...v2.80.1

v2.80.0: Prepare klog release for Kubernetes v1.26 (Take 1)

Compare Source

What's Changed

Full Changelog: kubernetes/klog@v2.70.1...v2.80.0

v2.70.1: Prepare klog release for Kubernetes v1.25 (Take 2)

Compare Source

What's Changed

Full Changelog: kubernetes/klog@v2.70.0...v2.70.1

v2.70.0: Prepare klog release for Kubernetes v1.25 (Take 1)

Compare Source

What's Changed

New Contributors

Full Changelog: kubernetes/klog@v2.60.1...v2.70.0

v2.60.1: Prepare klog release for Kubernetes v1.24 (Take 6)

Compare Source

What's Changed

Full Changelog: kubernetes/klog@v2.60.0...v2.60.1

v2.60.0: Prepare klog release for Kubernetes v1.24 (Take 5)

Compare Source

What's Changed

  • SetContextualLogger: remove unintentionally merged API call by @​pohly in #​308

Full Changelog: kubernetes/klog@v2.50.2...v2.60.0

v2.50.2

Compare Source

v2.50.1: Prepare klog release for Kubernetes v1.24 (Take 4)

Compare Source

What's Changed

Full Changelog: kubernetes/klog@v2.50.0...v2.50.1

v2.50.0: Prepare klog release for Kubernetes v1.24 (Take 3)

Compare Source

What's Changed

New Contributors

Full Changelog: kubernetes/klog@v2.40.1...v2.50.0

v2.40.1: Prepare klog release for Kubernetes v1.24 (Take 2)

Compare Source

What's Changed

New Contributors

Full Changelog: kubernetes/klog@v2.40.0...v2.40.1

v2.40.0: Prepare klog release for Kubernetes v1.24

Compare Source

What's Changed

Known Issues

New Contributors

Full Changelog: kubernetes/klog@v2.30.0...v2.40.0

v2.30.0: Prepare klog release for Kubernetes v1.23 (take 2)

Compare Source

What's Changed

New Contributors

Full Changelog: kubernetes/klog@v2.20.0...v2.30.0

v2.20.0: Prepare klog release for Kubernetes v1.23

Compare Source

Changes are here : kubernetes/klog@v2.10.0...v2.20.0

since we moved to logr v1.0.0, there are incompatible changes:

- klogger.Enabled: changed from func() bool to func(int) bool
- klogger.Info: changed from func(string, ...interface{}) to func(int, string, ...interface{})
- klogger.V: removed
- klogger.WithCallDepth: changed from func(int) github.com/go-logr/logr.Logger to func(int) github.com/go-logr/logr.LogSink
- klogger.WithName: changed from func(string) github.com/go-logr/logr.Logger to func(string) github.com/go-logr/logr.LogSink
- klogger.WithValues: changed from func(...interface{}) github.com/go-logr/logr.Logger to func(...interface{}) github.com/go-logr/logr.LogSink

83653a6 Update to newest versions of golang 1.17.x
d648c2e fix file-based filtering symbolization
8ee3d65 export ClearLogger
4171f3c Switching to logr tag v1.0.0
9ab3c2b add serathius as approvers of klog

v2.10.0: One more change to support 1.22 release

Compare Source

Changes are here : kubernetes/klog@v2.9.0...v2.10.0

new function added:

func KObjs(arg interface{}) []ObjectRef

v2.9.0: Prepare release for Kubernetes v1.22

Compare Source

Changes are here : kubernetes/klog@v2.8.0...v2.9.0

6a9ef3f fix typo
59f7cb5 fix byte array display in InfoS and ErrorS
cf22f1e Call logr with call depth
e95c7e3 make SetLogger thread-safe
2728fe1 check usage of format specifier in structured log func
a18bc97 Fix by pr suggestions
4e4135c Add check for InfoS & ErrorS parameters

v2.8.0: Bug fixes for structured logging for Kubernetes v1.21

Compare Source

v2.7.0: Miscellaneous fixes for structured logging for Kubernetes v1.21

Compare Source

Changes are here : kubernetes/klog@v2.6.0...v2.7.0

v2.6.0: Adding a linter for Kubernetes v1.21

Compare Source

Changes are here : kubernetes/klog@v2.5.0...v2.6.0

please see https://github.com/kubernetes/klog/tree/master/hack/tools/logcheck

v2.5.0: Prepare release for Kubernetes v1.21

Compare Source

Changes are here : kubernetes/klog@v2.4.0...v2.5.0

klog.go has new API:

+func ErrorSDepth(depth int, err error, msg string, keysAndValues ...interface{}) {
+func InfoSDepth(depth int, msg string, keysAndValues ...interface{}) {

klogr/klogr.go has new API:

func (l klogger) WithCallDepth(depth int) logr.Logger {
func NewWithOptions(options ...Option) logr.Logger {
func WithFormat(format Format) Option {

v2.4.0: Prepare release for Kubernetes v1.20

Compare Source

Changes are here : kubernetes/klog@v2.3.0...v2.4.0

v2.3.0: Fix Typo-ed Method Error -> ErrorS

Compare Source

Changes are here : kubernetes/klog@v2.2.0...v2.3.0

v2.2.0: Dependency update and bugfix for InfoS

Compare Source

  • 2e691eb Fix missing fields in verbose InfoS
  • 966c986 feat use go-logr v0.2.0

Changes are here : kubernetes/klog@v2.1.0...v2.2.0

v2.1.0: Better support for Structured Logging

Compare Source

We are now enforcing API compatibility, added Windows based tests, and have tweaked the structured logging methods after some real world experience updating kubernetes main repo.

  • bbd9ca1 Add tests for error in InfoS
  • 1ccc0e1 fix imported bug time encode format form kvlistFormat
  • dd4d1a6 fix typo in README.md
  • 49123d4 ErrorS(nil, ...) should call loggr.Error(nil, ...)
  • 5b199cd Fix documentation for V(level)
  • d1eb30f Add apidiff script to check go signature changes
  • dc505bf Switch slack channel to #klog
  • a47ebb9 Add example for co-existence of klog v1 and v2
  • 134f148 logName(): lazily lookup userName instead of on init()
  • db06a1b fix serialization of special html chars
  • 5727d2a Fix Windows integration tests
  • edbc1d3 test(*): TestRollover failed randomly on Windows
  • 6f99060 Add LogToStderr, a programatic way to log exclusively to stderr or not

v2.0.0: Release to support Kubernetes v1.19

Compare Source

Beware of type change: Verbose

New Methods:

  • SetLogger (override logger to set a custom implementation)
  • InfoS (structured logging)
  • ErrorS (structured logging)

Changes are here : kubernetes/klog@v2.0.0-rc.1...v2.0.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested review from a team and janetkuo as code owners November 24, 2025 02:08
@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist bot commented Nov 24, 2025

Summary of Changes

Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the k8s.io/klog dependency to its latest major version, v2.130.1. This upgrade is crucial for incorporating modern logging practices, including structured logging, and benefiting from a wide array of stability improvements and new features accumulated over many releases of the klog library. The change ensures the project aligns with current Kubernetes logging standards and best practices.

Highlights

  • Dependency Update: The k8s.io/klog module has been updated from version v1.0.0 to v2.130.1. This is a significant major version upgrade.
  • Major Version Migration: This update involves migrating from klog v1 to v2, which introduces numerous new features, bug fixes, and several API changes, particularly around structured logging capabilities.
  • Enhanced Logging Features: The new klog/v2 version brings improvements such as InfoS and ErrorS for structured logging, better handling of contextual logging, and various performance and stability enhancements across multiple releases.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 24, 2025
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR attempts to upgrade k8s.io/klog to v2, but it introduces a critical issue. The upgrade is a major version change that requires updating import paths in the Go source code, which is missing from this PR. This will cause the build to fail. Additionally, the change creates a duplicate dependency in go.mod. I've recommended reverting the change until the necessary source code updates can be included.

pre-sync/oci-image-verification/go.mod Outdated
Comment on lines 13 to 14
k8s.io/klog/v2 v2.130.1
k8s.io/klog/v2 v2.130.1
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This dependency update has two issues:

  • Breaking Change: Upgrading k8s.io/klog from v1 to v2 is a major version change that requires updating import paths in the source code (from k8s.io/klog to k8s.io/klog/v2). Since main.go still imports k8s.io/klog, this change will break the build.
  • Duplicate Dependency: This change also introduces a duplicate requirement for k8s.io/klog/v2.

This PR is incomplete and will break the build. It should be reverted. To fix this properly, the import paths in the Go source files need to be updated to k8s.io/klog/v2 and then go mod tidy should be run to clean up the dependencies.

Suggested change
k8s.io/klog/v2 v2.130.1
k8s.io/klog/v2 v2.130.1
k8s.io/klog v1.0.0
k8s.io/klog/v2 v2.130.1

@renovate-bot renovate-bot force-pushed the renovate/k8s.io-klog-2.x branch from c4d8201 to 071be94 Compare November 24, 2025 02:15
@renovate-bot renovate-bot force-pushed the renovate/k8s.io-klog-2.x branch from 071be94 to 0e8b291 Compare December 15, 2025 16:01
@renovate-bot renovate-bot force-pushed the renovate/k8s.io-klog-2.x branch from 0e8b291 to 2be2e60 Compare December 15, 2025 20:36
@forking-renovate
Copy link
Copy Markdown

forking-renovate bot commented Jan 13, 2026

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@renovate-bot renovate-bot changed the title fix(deps): update module k8s.io/klog to v2 fix(deps): update module k8s.io/klog to v2 - abandoned Mar 20, 2026
@forking-renovate
Copy link
Copy Markdown

forking-renovate bot commented Mar 20, 2026

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janetkuo janetkuo Awaiting requested review from janetkuo janetkuo is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@renovate-bot @bourgeoisor