Open
Conversation
Swiftb0y
reviewed
Feb 2, 2025
Collaborator
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
large lgtm, couple thoughts
Comment on lines
+74
to
+95
| impl Serialize for Collection { | ||
| fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error> | ||
| where | ||
| S: Serializer, | ||
| { | ||
| #[derive(Serialize)] | ||
| struct Value<'a> { | ||
| /// Number of TRACK in COLLECTION | ||
| #[serde(rename = "@Count")] | ||
| entries: usize, | ||
| /// Tracks | ||
| #[serde(rename = "TRACK")] | ||
| tracks: &'a Vec<Track>, | ||
| } | ||
|
|
||
| let value = Value { | ||
| entries: self.tracks.len(), | ||
| tracks: &self.tracks, | ||
| }; | ||
|
|
||
| value.serialize(serializer) | ||
| } |
Collaborator
There was a problem hiding this comment.
I feel like this could be simplified by using #[serde(getter = "tracks.len()")] instead?
Owner
Author
There was a problem hiding this comment.
Not sure if this works, looks like getter is meant for another use case and calls the method for a remote type? https://serde.rs/field-attrs.html#getter
Holzhaus
force-pushed
the
xml-improvements
branch
from
be6b2a0 to
1bb917e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.