This repository was archived by the owner on Oct 1, 2023. It is now read-only.
Added option to specify custom clientId for the MqttClient#89
Open
Zolli wants to merge 1 commit intoHypfer:masterfrom
Open
Added option to specify custom clientId for the MqttClient#89Zolli wants to merge 1 commit intoHypfer:masterfrom
Zolli wants to merge 1 commit intoHypfer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hy @Hypfer , i made this pull request to allow specify a custom clientId for the MQTT client. The reason behind this that now (according to MQTT V5 specification) servers require a permanent clientId for each connected client.
The used Mqtt.js library default bhaviour is that the client generate a unique client id for the session during each connection, so this behaviour breaks the V5 auth mechanism, to fix this i allowd to specify a permanent clientId in the config.
This PR not breaks existing installations because when the config is not specified or the value is empty the library still generate random clientId`s as before, tested locally with every mentioned scenario.
The connection is also tested and verified using the VerneMq MQTT server.