Allow multiple account links with the same sortOrder#1
Open
rhoerr wants to merge 3 commits intoJaJuMa-GmbH:masterfrom
Open
Allow multiple account links with the same sortOrder#1rhoerr wants to merge 3 commits intoJaJuMa-GmbH:masterfrom
rhoerr wants to merge 3 commits intoJaJuMa-GmbH:masterfrom
Conversation
Author
|
Pardon the trailing newline change, I can't fix it from the GitHub web UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug with the module. It currently keys customer account links by sortOrder. If multiple links have the same sortOrder value, only the last one will survive.
I found this because of a company accounts module that has 5+ links with sortOrder of 102. The custom links wouldn't appear, even with third-party links enabled. This code fixes it.