Redesign GDScript settings page#582
Merged
Merged
Conversation
Ivan Šachov (van800)
force-pushed
the
shakhov/settings
branch
from
dc58289 to
cd647c1
Compare
… Rename plugins: GdScript -> Godot, Godot support -> Godot.NET (cherry picked from commit ae4e3a8)
Ivan Šachov (van800)
force-pushed
the
shakhov/settings
branch
2 times, most recently
from
23b77df to
73c4d13
Compare
Ivan Šachov (van800)
requested review from
martin_tomanek (Finishxx) and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
This PR updates the Godot/GDScript settings UI, reorganizing the GDScript settings page into clearer sections and simplifying LSP port configuration, while also adjusting several user-facing display names (“Godot Engine” → “Godot.NET” and “GDScript Settings” → “Godot Settings”).
Changes:
- Rebuilt the GDScript settings UI using the IntelliJ UI DSL and grouped options into LSP/Documentation/Completion/Other sections.
- Simplified LSP port configuration by removing the “dynamic port” setting and making dynamic-port behavior depend on the selected connection mode.
- Updated various display names/labels in plugin descriptors and resource bundles.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rider/src/main/resources/META-INF/plugin.xml | Renames the Rider settings page display name to “Godot.NET”. |
| rider/src/main/resources/messages/GodotPluginBundle.properties | Updates the localized configurable name to “Godot.NET”. |
| resharper/src/Application/UI/Options/GodotOptionsPage.cs | Renames the ReSharper options page title constant to “Godot.NET”. |
| resharper/godot-support.sln.DotSettings | Updates solution-level ReSharper naming rules/settings. |
| gdscript/src/main/resources/META-INF/plugin.xml | Changes the settings configurable display key to use a “Godot” plugin name key. |
| gdscript/src/main/resources/messages/GdScriptBundle.properties | Adds new section labels and updates settings page strings to match the redesigned UI. |
| gdscript/src/main/kotlin/gdscript/settings/GdSettingsConfigurable.kt | Removes persistence/apply/reset handling for the removed dynamic-port setting. |
| gdscript/src/main/kotlin/gdscript/settings/GdSettingsComponent.kt | Rebuilds the settings UI, replaces port text field with an int spinner, and updates enable/visibility logic. |
| gdscript/src/main/kotlin/gdscript/settings/GdSearchableOptionContributor.kt | Adjusts settings search indexing tokens/display name key. |
| gdscript/src/main/kotlin/gdscript/settings/GdProjectState.kt | Removes the persisted lspUseDynamicPort setting. |
| gdscript/src/main/kotlin/gdscript/settings/GdLspSettingsFlowService.kt | Removes the dynamic-port flow and related updates. |
| gdscript/src/main/kotlin/gdscript/lsp/GodotLspServerSupportProvider.kt | Removes dynamic-port setting subscription and derives dynamic behavior from connection mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
157
to
161
| var lspRemoteHostPort: Int | ||
| get() = lspRemoteHostPortTf.text.toIntOrNull() ?: 6005 | ||
| get() = lspRemoteHostPortSpinner.number | ||
| set(newStatus) { | ||
| lspRemoteHostPortTf.text = newStatus.toString() | ||
| } | ||
|
|
||
| var lspUseDynamicPort: Boolean | ||
| get() = lspUseDynamicPortCheck.isSelected | ||
| set(newStatus) { | ||
| lspUseDynamicPortCheck.isSelected = newStatus | ||
| updateLspControlsState() | ||
| lspRemoteHostPortSpinner.value = newStatus | ||
| } |
martin_tomanek (Finishxx)
left a comment
martin_tomanek (Finishxx)
left a comment
Contributor
There was a problem hiding this comment.
I wonder what the rationale is for removing the option for a dynamic free port when not using headless?
| settings.configurable.name.gdscript.settings=Godot Settings | ||
| settings.separator.completion=Completion | ||
| settings.separator.lsp=GDScript Language Server | ||
| settings.label.lsp.connection.mode=Connecting to language server |
Contributor
There was a problem hiding this comment.
Maybe "Language Server Connection" or "Connection Type" or just "Connection"?
Member
Author
Dynamic port is possible, when we control both godot port and rider port. We control Godot port only when we start it. We start it and pass port in the command line argument. |
Ivan Šachov (van800)
force-pushed
the
shakhov/settings
branch
from
73c4d13 to
474ac53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.