Remove dtcc domain from the abused list #39040
Remove dtcc domain from the abused list #39040only1elii wants to merge 4 commits intoJetBrains:masterfrom
Conversation
Adding Delaware Technical Community College DTCC domain informationn
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This is a real accredited institution with a Computer Science Major
…mputer Science program Remove 'dtcc.edu' from the list of abused domains as this belongs to Delaware Technical Community College which is an accredited institution with a Computer Science major in the State of Delaware.
There was a problem hiding this comment.
Pull request overview
This PR aims to remove dtcc.edu (Delaware Technical Community College) from the abused domain list so it is no longer treated as an untrusted academic email domain.
Changes:
- Removed
dtcc.edufromlib/domains/abused.txt. - Added a new domain entry file for DTCC (but currently in an incorrect location/format).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/domains/dtcc | Adds a DTCC entry, but the placement/format will be interpreted incorrectly by the domain compiler/lookup logic. |
| lib/domains/abused.txt | Removes dtcc.edu from the abused list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,2 @@ | |||
| Delaware Technical Community College | |||
| dtcc.edu | |||
There was a problem hiding this comment.
lib/domains/dtcc is being added at the root and without a .txt extension. In this repo, domain entries are discovered by path segments under lib/domains (e.g. lib/domains/edu/<domain>.txt for <domain>.edu). Adding a root-level file named dtcc will cause the compiler (src/main/kotlin/swot/Compiler.kt) to treat dtcc as an academic TLD (i.e. .dtcc), which is incorrect and will broaden matches unexpectedly. Move this entry to lib/domains/edu/dtcc.txt and keep the file contents as school name(s) only (the domain should be implied by the path/filename).
| dtcc.edu |
|
@only1elii lib/domains/abused.txt: this request has file path that is not expected in a pull request. This repository rules explain what kind of contributions are expected in pull requests. We'll review your request as soon as we can. If the issue concerns a domain that we do not accept due to abuse, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students). |
Remove dtcc.edu from the abused list, as this is an Accredited institution, Delaware Technical Community College, with a Computer Science Major.