throw ArgumentError on transitiveclosure!(::MetaGraph)

[drbergman]

This is responsive to #89

previously, this would not return an error but would not update the underlying graph structure.

Note: simply calling transitiveclosure!(G.graph) also fails as this does not update the metadata, e.g. G.edge_data.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (1ea0c41) to head (f369715).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   90.09%   90.15%   +0.06%     
==========================================
  Files           6        6              
  Lines         323      325       +2     
==========================================
+ Hits          291      293       +2     
  Misses         32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gdalle]

can you add tests to ensure code coverage?

[drbergman]

added a test. awaiting maintainer approval for testing

[gdalle]

The issue is that you didn't extend the function from Graphs, you redefined a new one.

[drbergman]

Oh yeah! Thanks for catching that!

[gdalle]

thanks!