Open
Conversation
This PR is inspired by the Lesson 4 `index.html` changes in KhronosGroup#326 and fixes up the `handler::single_task` invocations in a couple of places to make sure they are correct. * Change `parallel_for` to `single_task` in early example where we haven't defined `bufO` yet to call `bufO.get_range()` on. * Remove `(id<1> i)` parameter for `single_task` lambda invocation, as this shouldn't have any parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is inspired by the Lesson 4
index.htmlchanges in #326 and fixes up thehandler::single_taskinvocations in a couple of places to make sure they are correct.parallel_fortosingle_taskin early example where we haven't definedbufOyet to callbufO.get_range()on.(id<1> i)parameter forsingle_tasklambda invocation, as this shouldn't have any parameters.