Skip to content

feat(WebGPU): add polydata backface material and local culling#3475

Merged
finetjul merged 1 commit intoKitware:masterfrom
daker:feat-backface-webgpu
Apr 10, 2026
Merged

feat(WebGPU): add polydata backface material and local culling#3475
finetjul merged 1 commit intoKitware:masterfrom
daker:feat-backface-webgpu

Conversation

@daker
Copy link
Copy Markdown
Collaborator

@daker daker commented Apr 7, 2026 •
edited
Loading

Context

Add backface material support to the WebGPU polydata mapper.

Results

image

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker daker marked this pull request as ready for review April 7, 2026 15:47
@daker daker mentioned this pull request Apr 7, 2026
Open
34 tasks
finetjul
finetjul reviewed Apr 7, 2026
View reviewed changes
Comment thread Sources/Rendering/WebGPU/CellArrayMapper/index.js
Comment thread Sources/Rendering/WebGPU/Pipeline/index.js Outdated
Comment thread Sources/Rendering/WebGPU/Pipeline/index.js
@daker daker force-pushed the feat-backface-webgpu branch from 5e0462e to 660fe44 Compare April 8, 2026 09:33
@daker daker requested a review from finetjul April 9, 2026 07:56
finetjul
finetjul approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Sources/Rendering/WebGPU/CellArrayMapper/index.js
Comment thread Sources/Rendering/WebGPU/CellArrayMapper/index.js
@daker
feat(WebGPU): add polydata backface material and local culling
8c91272 
Add backface material support to the WebGPU polydata mapper.
@daker daker force-pushed the feat-backface-webgpu branch from 660fe44 to 8c91272 Compare April 9, 2026 13:41
@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Apr 9, 2026

@finetjul would it be possible to merge the approved PRs around CellArrayMapper so I can continue working on the other tasks ? or would you prefer to wait for an additional approval ? I just want to avoid potential conflicts and issues with dependent PRs.

finetjul
finetjul reviewed Apr 10, 2026
View reviewed changes
Comment thread Sources/Rendering/WebGPU/CellArrayMapper/index.js
' let PBR = mapperUBO.DiffuseIntensity * kD * diffuse + kS * specular;',
' computedColor = vec4<f32>(PBR + emission, mapperUBO.Opacity);',
' let specularMaterial = specularColor.rgb * specularColor.a;',
' let PBR = diffuseIntensity * kD * diffuse + kS * specularIntensity * specular * specularMaterial;',
Copy link
Copy Markdown
Member

@finetjul finetjul Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sankhesh do you confirm adding specularMaterial is correct here ?

@finetjul
Copy link
Copy Markdown
Member

finetjul commented Apr 10, 2026

@finetjul would it be possible to merge the approved PRs around CellArrayMapper so I can continue working on the other tasks ? or would you prefer to wait for an additional approval ? I just want to avoid potential conflicts and issues with dependent PRs.

I can merge this one, for the other ones, I would prefer a WebGPU savvy person to review them.

@finetjul finetjul added this pull request to the merge queue Apr 10, 2026
Merged via the queue into Kitware:master with commit e31b001 Apr 10, 2026
2 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

🎉 This PR is included in version 35.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Apr 10, 2026
@daker daker deleted the feat-backface-webgpu branch April 10, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@finetjul finetjul finetjul approved these changes

Assignees

No one assigned

Labels

released Automated label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daker @finetjul