synq: fix stale body_call_length==0 doc for arg-internal sentinel#155
Merged
LalitMaganti merged 1 commit intomainfrom Apr 16, 2026
Merged
synq: fix stale body_call_length==0 doc for arg-internal sentinel#155LalitMaganti merged 1 commit intomainfrom
LalitMaganti merged 1 commit intomainfrom
Conversation
The public header, internal header, and session.rs test comment all claimed the arg-internal case was signalled by `body_call_length == 0`, but the implementation sets both `body_call_offset` and `body_call_length` to `SYNTAQLITE_MACRO_BODY_CALL_ARG_INTERNAL` (UINT32_MAX) — and that is what the public sentinel macro documents at parser.h:236. Downstream consumers (e.g. google/perfetto#5472) that trusted the stale comment ended up pushing UINT32_MAX offsets into their rewriter and crashing on overflow. Pure doc fix — no behavior change.
Playwright Reports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The public header, internal header, and a session.rs test comment all said the arg-internal case for a nested macro call was signalled by
body_call_length == 0. That contradicts the implementation:parser_macros.c:530-535sets bothbody_call_offsetandbody_call_lengthtoSYNTAQLITE_MACRO_BODY_CALL_ARG_INTERNAL(=UINT32_MAX), matching the sentinel defined atparser.h:236and the Rust docs attypes.rs:274-277.Downstream consumers that trusted the stale comment can crash. Concrete example: google/perfetto#5472 filtered with
if (c.body_call_length == 0) continue;, which never trips for arg-internal calls, so aRewriteItem{start = UINT32_MAX, end = UINT32_MAX + UINT32_MAX}ended up inSqlSource::Rewriterand tripped itsstart <= endcheck.Changes
Pure documentation fix — no behavior change:
syntaqlite-syntax/include/syntaqlite/parser.h— refer toSYNTAQLITE_MACRO_BODY_CALL_ARG_INTERNAL(UINT32_MAX) as the arg-internal sentinel on both fields.syntaqlite-syntax/csrc/parser_internal.h— same fix on theSynqExpansionLayerfields.syntaqlite-syntax/src/parser/session.rs— update the test comment that still saidbody_call_length == 0.